Add Psalm security checks (has_quotes only) and fix detected issues
#20407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
11.0/psalm-security-analysis
branch
from
381f91e to
8bbcc3f
Compare
2 tasks
cedric-anne
force-pushed
the
11.0/psalm-security-analysis
branch
from
8bbcc3f to
c163ac4
Compare
cedric-anne
changed the title
has_quotes only) and fix detected issues
cedric-anne
commented
Jul 31, 2025
Comment on lines
-6593
to
-6597
| // Display extra html if needed | ||
| if (!empty($options['after_display'] ?? "")) { | ||
| echo $options['after_display']; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This was used only by front/problem.form.php and front/ticket.form.php, and was now a security flaw since the request is not anymore autosanitized.
cedric-anne
commented
Jul 31, 2025
|
|
||
| if (!$compat) { | ||
| echo htmlescape(Plugin::messageIncompatible( | ||
| echo Plugin::messageIncompatible( |
Member
Author
There was a problem hiding this comment.
This message and the following are caught inside an output buffer that is later escaped (see $error .= "<span class='error'>" . htmlescape(ob_get_contents()) . "</span>"; in src/Glpi/Marketplace/View.php).
The buffer content can also contain messages outputed by plugins, it is safer to escape its whole content.
cedric-anne
force-pushed
the
11.0/psalm-security-analysis
branch
from
c163ac4 to
a7b7cb4
Compare
AdrienClairembault
approved these changes
Jul 31, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
I tried again to run a security analysis on our code with Psalm, and now we have fixed many escaping issues, it seems that results are consistents. Also, maybe a few issues have been fixed in Psalm.
For the moment, I silented all errors expect the
TaintedTextWithQuoteserrors.I did not fixed all detected errors yet, this will be done in the next few days.