Feature: improve logging of user assignment and deassigment #21202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now done in CommonITILActor isntead of teh child classes. This allows it to work for tickets, changes and problems
Member
If there are existing tests testing the produced logs entries, please indicate their class/method name, so we can check them. Otherwise, you should add tests for each impacted class and you can see how it is done in the |
cedric-anne
requested review from
AdrienClairembault,
cedric-anne and
trasher
trasher
reviewed
Oct 27, 2025
| } | ||
|
|
||
| // Values from CommonITILObject::getSearchOptionsActors() | ||
| if (static::$itemtype_2 === 'User') { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (static::$itemtype_2 === 'User') { | |
| if (static::$itemtype_2 === User::class) { |
| case CommonITILActor::ASSIGN: | ||
| return 5; | ||
| } | ||
| } elseif (static::$itemtype_2 === 'Group') { |
Contributor
There was a problem hiding this comment.
Suggested change
| } elseif (static::$itemtype_2 === 'Group') { | |
| } elseif (static::$itemtype_2 === Group::class) { |
| case CommonITILActor::ASSIGN: | ||
| return 8; | ||
| } | ||
| } elseif (static::$itemtype_2 === 'Supplier') { |
Contributor
There was a problem hiding this comment.
Suggested change
| } elseif (static::$itemtype_2 === 'Supplier') { | |
| } elseif (static::$itemtype_2 === Supplier::class) { |
trasher
reviewed
Oct 27, 2025
| } | ||
|
|
||
| $current_log_option = $this -> _force_log_option; | ||
| $this -> _force_log_option = $this -> get_force_log_option(); |
Contributor
There was a problem hiding this comment.
Suggested change
| $this -> _force_log_option = $this -> get_force_log_option(); | |
| $this->_force_log_option = $this->get_force_log_option(); |
| $current_log_option = $this -> _force_log_option; | ||
| $this -> _force_log_option = $this -> get_force_log_option(); | ||
| parent::post_addItem(); | ||
| $this -> _force_log_option = $current_log_option; |
Contributor
There was a problem hiding this comment.
Suggested change
| $this -> _force_log_option = $current_log_option; | |
| $this->_force_log_option = $current_log_option; |
| $current_log_option = $this -> _force_log_option; | ||
| $this -> _force_log_option = $this -> get_force_log_option(); | ||
| parent::post_deleteFromDB(); | ||
| $this -> _force_log_option = $current_log_option; |
Contributor
There was a problem hiding this comment.
Suggested change
| $this -> _force_log_option = $current_log_option; | |
| $this->_force_log_option = $current_log_option; |
Comment on lines
+215
to
+216
| $current_log_option = $this -> _force_log_option; | ||
| $this -> _force_log_option = $this -> get_force_log_option(); |
Contributor
There was a problem hiding this comment.
Suggested change
| $current_log_option = $this -> _force_log_option; | |
| $this -> _force_log_option = $this -> get_force_log_option(); | |
| $current_log_option = $this->_force_log_option; | |
| $this->_force_log_option = $this->get_force_log_option(); |
trasher
reviewed
Oct 27, 2025
Contributor
trasher
left a comment
trasher
left a comment
There was a problem hiding this comment.
After a quick look, this seems globally OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
The added code is covered by existing tests. If you need more tests for this Feature could you advise where to place them ?
Description
This pull requests does two things:
It adds recording to which position an Actor is assigned for problems and changes.
It adds recording when a user is removed from a position for tickets, problems and changes.