Skip to content

Conversation

@ccailly
Copy link
Member

@ccailly ccailly commented Nov 10, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Currently, we display a warning message if pending reasons have been defined but notifications are not enabled.
However, the current system defines "empty" pending reasons when the user puts the ticket on pending using the toggle at the bottom of the followup or task form.
This fix strengthens the conditions for displaying the warning so that the reasons for waiting are considered "valid."

@ccailly ccailly self-assigned this Nov 10, 2025
@ccailly ccailly marked this pull request as draft November 10, 2025 09:45
@ccailly ccailly force-pushed the fix/pending-reason-notification-warning branch from 1af5c9a to c8258b6 Compare November 10, 2025 09:50
@ccailly ccailly marked this pull request as ready for review November 10, 2025 09:51
@cconard96
Copy link
Contributor

If the pending reasons are invalid, is it safe to prevent them from being added to begin with?

IMO even with the invalid pending reasons being ignored, there are still some things that remain unaddressed for user experience:

  • Is it important to have this kind of warning specifically for the auto_reminder notification when we don't do anything like this for other notifications?
  • Should this notification be enabled by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pending reason warning on homepage confusing users

4 participants