-
Notifications
You must be signed in to change notification settings - Fork 104
ci: fix comparison types in workflow #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
asraa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j2kun on the previous run it looked like I got an error message fetching the # of commits that the gh command wasn't run in a .git directory. i added a checkout step before that. could you try submitting another review?
Signed-off-by: Asra Ali <[email protected]>
|
I got the same error and found out that there was a typo in the PR number env var and that is the issue. please approve me again! :P |
Signed-off-by: Asra Ali <[email protected]>
|
|
ugh!! i looked online and secrets aren't accessible from forks until they have approval, so i would think this does have access? and i need a better debug message (is the repository secret just not working?!) |
See this failure

also removed the squash ready labeling