Minor cleanup of emitters #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Centralize isDebugPort and canonicalizeDebugPort - Add a helper for the common parts of function emitters in OpenFhe - Centralize dialect registration for openfhe emitters - Remove unused member variable from ForwardInsertToExtract
j2kun
force-pushed
the
cleanup-emitters
branch
from
01c7735 to
346d5e6
Compare
asraa
approved these changes
Sep 17, 2025
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup of emitters extracted from #2226
isDebugPortandcanonicalizeDebugPort