Replace some uses of return failure() with notifyMatchFailure
#2382
+357
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
force-pushed
the
notifyMatchFailure
branch
from
0e03d1e to
aec4da1
Compare
asraa
approved these changes
Nov 6, 2025
lib/Dialect/Polynomial/Conversions/PolynomialToModArith/PolynomialToModArith.cpp
Show resolved
Hide resolved
j2kun
force-pushed
the
notifyMatchFailure
branch
from
aec4da1 to
de474ac
Compare
Collaborator
Author
|
Addressed comments and squashed |
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2258