Skip to content

add ipython-profile support #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add ipython-profile support #266

wants to merge 4 commits into from

Conversation

@woutervh
Copy link
Contributor

@woutervh woutervh commented Mar 13, 2023

  • add ipython-profile support

Wouter Vanden Hove and others added 3 commits March 12, 2023 02:56
blacken codebase
77a9924
@woutervh
Merge branch 'gotcha:master' into master
7c303b1
@woutervh
add ipython-profile support (#1)
63796e9 
* add ipython-profile support

* add tests to fetch ipytohn_profiler from config

---------

Co-authored-by: Wouter Vanden Hove <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.02%. Comparing base (3326c07) to head (9726ed8).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ipdb/__main__.py 70.00% 6 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   81.64%   81.02%   -0.62%     
==========================================
  Files           7        7              
  Lines         512      564      +52     
==========================================
+ Hits          418      457      +39     
- Misses         94      107      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woutervh woutervh mentioned this pull request Mar 13, 2023
Open
gotcha
gotcha reviewed Mar 22, 2023
View reviewed changes
gotcha
gotcha reviewed Mar 22, 2023
View reviewed changes
gotcha
gotcha reviewed Mar 22, 2023
View reviewed changes
@gotcha
Copy link
Owner

gotcha commented Mar 22, 2023

Thanks for this PR.
I am sure it will be appreciated.
See my first comments. I'll dig deeper.

@woutervh
add ipython-profile support (#2)
9726ed8 
* add ipython-profile support

* add tests to fetch ipytohn_profiler from config

* cleanup profile-tests

---------

Co-authored-by: Wouter Vanden Hove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gotcha gotcha gotcha left review comments

+1 more reviewer

@ulgens ulgens ulgens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@woutervh @codecov-commenter @gotcha @ulgens