[reversetunnel] Use access point for cert auths #61274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run_until_success.sh |
Contributor
Author
|
Note that automating this test is challenging, and I believe this should be tackled separately. |
rosstimothy
approved these changes
Nov 12, 2025
Contributor
|
@okraport should this be backported to v17 as well? |
espadolini
approved these changes
Nov 12, 2025
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
Keep in mind that this is not a guarantee that we can connect, if the cache is also unhealthy or has failed to initialize and connectivity to auth is down we'll still error out when getting CAs.
public-teleport-github-review-bot
bot
removed the request for review
from cthach
cthach
approved these changes
Nov 12, 2025
Contributor
Author
Yes, thank you for pointing that out. Added the label. |
This change allows the agent dialer to use cached
results for hostCheckerFunc. In the case of a transient
grpc network failure, this allows the reverse tunnel
to be re-established before the grpc timeout takes place.
Test plan:
- [ ] Spawn two Linux VMs, one for auth/proxy and one for node.
Simulate network change by toggling one of two interfaces on the node,
measure time for the reverse tunnel to be functional again.
In local testing with 5 runs this on average brings the recovery time
to 2m39s from 3m45s.
Changelog: Improve reverse tunnel dialing recovery from default route changes by 1min on average.
okraport
force-pushed
the
okraport/reversetunnel-dialer-use-cache
branch
from
c3ffc83 to
49a1c52
Compare
Contributor
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the agent dialer to use cached
results for hostCheckerFunc. In the case of a transient grpc network failure, this allows the reverse tunnel to be re-established before the grpc timeout takes place.
Test plan:
In local testing with 5 runs this on average brings the recovery time to 2m39s from 3m45s.
Changelog: Improve reverse tunnel dialing recovery from default route changes by 1min on average.