fix: auth without taskAffinity

[2paperstar]

Summary by CodeRabbit

릴리즈 노트

• Chores
  • 버전을 1.0.17로 업데이트했습니다.
  • 웹 인증 관련 종속성을 안정화했습니다.
  • 앱 구성을 최적화했습니다.

[coderabbitai]

📝 Walkthrough

Walkthrough

안드로이드 매니페스트에서 MainActivity와 CallbackActivity의 빈 taskAffinity 속성을 제거하고, 프로젝트 버전을 1.0.17로 업데이트했으며, flutter_web_auth_2 의존성을 5.0.0-alpha.7에서 4.1.0으로 다운그레이드했습니다.

Changes

코호트 / 파일(들)	변경 요약
안드로이드 매니페스트 정리 android/app/src/main/AndroidManifest.xml	MainActivity와 CallbackActivity에서 빈 android:taskAffinity="" 속성 제거
프로젝트 메타데이터 pubspec.yaml	버전을 1.0.16에서 1.0.17로 업데이트
의존성 다운그레이드 pubspec.yaml	flutter_web_auth_2를 ^5.0.0-alpha.7에서 ^4.1.0으로 다운그레이드

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• 변경 사항은 구성 속성 정리 및 의존성 버전 조정으로 단순하고 명확합니다.
• flutter_web_auth_2 다운그레이드는 호환성 확인 필요 (관련 코드 변경 없음);

Possibly related PRs

• fix: android OAuth window not closed #207: 동일한 AndroidManifest의 CallbackActivity taskAffinity 설정을 직접 수정하는 PR입니다.
• fix: android oauth window not closed #353: 같은 파일에서 flutter_web_auth_2 의존성을 반대 방향으로 업그레이드/다운그레이드하는 PR입니다.

Poem

🐰 빈 속성 치우고, 버전 높이고,
의존성 다시 돌아오니,
깔끔한 매니페스트 반짝반짝,
세세한 손길로 정리하는 기쁨! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR title directly describes the main changes: removing empty taskAffinity attributes from AndroidManifest to fix auth-related issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d467af3 and 1e4ee1e.

⛔ Files ignored due to path filters (1)

• pubspec.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• android/app/src/main/AndroidManifest.xml (1 hunks)
• pubspec.yaml (2 hunks)

🧰 Additional context used

🧠 Learnings (7)

📓 Common learnings

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 26
File: lib/app/modules/user/presentation/pages/profile_page.dart:13-30
Timestamp: 2025-05-19T04:24:10.184Z
Learning: The UI improvements for the authentication states in profile_page.dart (adding icons, localized resources, and better error handling) will be addressed in a separate PR rather than in the current one.

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 60
File: lib/app/modules/chat/presentation/pages/chat_room_page.dart:25-25
Timestamp: 2025-07-06T22:24:36.316Z
Learning: In gsainfoteam/pot-g-flutter, the dynamic title implementation for ChatRoomPage (replacing hardcoded "지송 003" with id parameter or chat room information) is planned to be implemented in a separate PR rather than the current chat room UI PR.

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 26
File: android/app/src/main/AndroidManifest.xml:29-38
Timestamp: 2025-05-19T04:29:21.842Z
Learning: The flutter_web_auth_2 library for Android OAuth authentication requires setting up a CallbackActivity with android:exported="true" and an intent-filter with the app's custom redirect scheme. The current implementation in AndroidManifest.xml follows the library's recommended setup.

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 26
File: android/app/src/main/AndroidManifest.xml:29-38
Timestamp: 2025-05-19T04:29:21.842Z
Learning: The flutter_web_auth_2 library for Android OAuth authentication requires setting up a CallbackActivity with android:exported="true" and an intent-filter with the app's custom redirect scheme. The implementation in AndroidManifest.xml follows the library's recommended setup and should not be modified with additional security attributes unless specifically needed.

📚 Learning: 2025-11-03T15:10:20.429Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 295
File: lib/app/modules/core/presentation/widgets/hidden_menu_button.dart:78-80
Timestamp: 2025-11-03T15:10:20.429Z
Learning: In gsainfoteam/pot-g-flutter, the `sdk:` constraint in pubspec.yaml refers to the Dart SDK version, not the Flutter SDK version. Flutter version numbers and Dart SDK version numbers are different (e.g., Flutter 3.35 ships with Dart SDK 3.9.0, Flutter 3.27 ships with Dart SDK 3.6.0).

Applied to files:

• pubspec.yaml

📚 Learning: 2025-04-06T01:13:59.987Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 20
File: lib/app/values/config.dart:1-9
Timestamp: 2025-04-06T01:13:59.987Z
Learning: In the pot-g-flutter project, .env files containing sensitive information like API keys are intentionally not tracked by git and are added to .gitignore for security reasons.

Applied to files:

• pubspec.yaml

📚 Learning: 2025-10-19T05:57:58.975Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 209
File: lib/app/modules/core/data/repositories/rest_app_version_repository.dart:56-70
Timestamp: 2025-10-19T05:57:58.975Z
Learning: In the pot-g-flutter project, the version API (/api/v1/version/) guarantees that all version strings (aosLatestVersion, aosMinVersion, iosLatestVersion, iosMinVersion) are always in valid semver format, so Version.parse() calls on these API responses do not require additional error handling.

Applied to files:

• pubspec.yaml

📚 Learning: 2025-10-10T12:57:36.455Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 166
File: lib/app/modules/chat/data/models/pot_accounting_info_model.dart:2-2
Timestamp: 2025-10-10T12:57:36.455Z
Learning: In the gsainfoteam/pot-g-flutter repository, `.freezed.dart` and `.g.dart` files generated by build_runner are gitignored. Do not suggest committing these generated files or flag them as missing in reviews.

Applied to files:

• pubspec.yaml

📚 Learning: 2025-05-19T04:29:21.842Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 26
File: android/app/src/main/AndroidManifest.xml:29-38
Timestamp: 2025-05-19T04:29:21.842Z
Learning: The flutter_web_auth_2 library for Android OAuth authentication requires setting up a CallbackActivity with android:exported="true" and an intent-filter with the app's custom redirect scheme. The current implementation in AndroidManifest.xml follows the library's recommended setup.

Applied to files:

• pubspec.yaml
• android/app/src/main/AndroidManifest.xml

📚 Learning: 2025-05-19T04:29:21.842Z

Learnt from: 2paperstar
Repo: gsainfoteam/pot-g-flutter PR: 26
File: android/app/src/main/AndroidManifest.xml:29-38
Timestamp: 2025-05-19T04:29:21.842Z
Learning: The flutter_web_auth_2 library for Android OAuth authentication requires setting up a CallbackActivity with android:exported="true" and an intent-filter with the app's custom redirect scheme. The implementation in AndroidManifest.xml follows the library's recommended setup and should not be modified with additional security attributes unless specifically needed.

Applied to files:

• pubspec.yaml
• android/app/src/main/AndroidManifest.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build iOS App and Test
• GitHub Check: Build Android App and Test

🔇 Additional comments (4)

pubspec.yaml (2)

4-4: 버전 업데이트가 적절합니다.

버그 수정을 위한 패치 버전 업데이트(1.0.16 → 1.0.17)는 의미론적 버전 관리 규칙을 준수합니다.

---

39-39: alpha 버전에서 안정화 버전으로의 다운그레이드 - 의도 확인 필요합니다.

flutter_web_auth_2를 ^5.0.0-alpha.7에서 ^4.1.0으로 다운그레이드하셨습니다. AndroidManifest.xml의 taskAffinity 제거와 함께 이 변경이 OAuth 윈도우 닫기 문제(PR 제목: "auth without taskAffinity")를 해결하는 것으로 보입니다. 버전 5.0.0-alpha.7에서의 구체적인 문제점을 확인하고 4.1.0이 모든 요구사항을 충족하는지 검증해주시기 바랍니다.

android/app/src/main/AndroidManifest.xml (2)

10-45: MainActivity에서 빈 taskAffinity 제거 - 적절한 수정입니다.

빈 android:taskAffinity="" 속성을 제거하여 Activity가 기본 작업 선호도(애플리케이션 패키지명)를 사용하도록 함으로써 Android OAuth 윈도우 라우팅 문제를 해결했습니다. 나머지 Activity 설정과 intent-filter는 모두 유지되어 있습니다.

---

47-57: CallbackActivity에서 빈 taskAffinity 제거 - flutter_web_auth_2 OAuth 처리 개선입니다.

CallbackActivity에서 빈 android:taskAffinity="" 속성을 제거했습니다. android:exported="true" 속성과 pot-g-idp-login-redirect 커스텀 스킴의 intent-filter는 유지되어, OAuth 콜백 처리에 필요한 설정이 모두 보존되었습니다. 이 변경으로 Activity 작업 라우팅이 정상화되어 OAuth 윈도우 닫기 문제가 해결될 것으로 예상됩니다.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}