Skip to content

MessageBuilder: fix typo #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MessageBuilder: fix typo #688

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff709e1
MessageBuilder: fix typo
stokito Oct 19, 2025
9a8a97e
MessageTest: use string concatenation instead of StringBuilder
stokito Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions smack-core/src/main/java/org/jivesoftware/smack/packet/MessageBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ private void copyFromMessage(Message message) {

@Override
protected void addStanzaSpecificAttributes(ToStringUtil.Builder builder) {
builder.addValue("type", type)
;
builder.addValue("type", type);
Copy link
Member

@Flowdalic Flowdalic Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an unrelated change in this commit. Also commit subject could be "[core] Fix typo in MessageBuilder"

Copy link
Contributor Author

@stokito stokito Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such kind of change (obvious code style cleanup) is too small for a separate commit: too many of them will distract. I had to mention it in a commit message, but again it will be longer to describe than see.

}

public MessageBuilder ofType(Message.Type type) {
Expand Down Expand Up @@ -138,7 +137,7 @@ public MessageBuilder addBody(String language, String body) {

for (Body currentBody : getExtensions(Body.class)) {
if (StringUtils.nullSafeCharSequenceEquals(language, currentBody.getLanguage())) {
throw new IllegalArgumentException("Bodyt with the language " + language + " already exists");
throw new IllegalArgumentException("Body with the language " + language + " already exists");
}
}

Expand Down