[VC-46486] Update venafi-connection-lib to v0.5.1 #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump github.com/jetstack/venafi-connection-lib to v0.5.1 - Bump k8s.io/utils to v0.0.0-20251002143259-bc988d571ff4 Signed-off-by: Richard Wall <[email protected]>
wallrj-cyberark
changed the title
Signed-off-by: Richard Wall <[email protected]>
inteon
approved these changes
Oct 31, 2025
wallrj-cyberark
commented
Nov 4, 2025
| rootCAs *x509.CertPool | ||
| ) | ||
| httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs) | ||
| httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext) |
Member
Author
There was a problem hiding this comment.
venafi-connection-lib v0.5.1 adds a debugging roundtripper to the default client so this is no longer necessary and causes duplicate logs if it is left here.
Before
{
"ts": 1762248249174.383,
"caller": "http_client/roundtripper_log.go:40",
"msg": "outgoing http request succeeded",
"v": 6,
"logger": "Run.gatherAndOutputData.postData",
"method": "PUT",
"uri": "https://snapshots-marshmallow-a1b2c3d4-integration.s3.amazonaws.com/k8s_snapshot/8f08a102-58ca-49cd-960e-debc5e0d3cd4/433c5166-e437-4412-9a5d-ce0edaab6d1e/20251104_092407_764.snapshot?AWSAccessKeyId=ASIAR53UX6ITKF3E45BC&Signature=tReq4nOu%2BUYUtMwlE%2BkY%2FnuDoZk%3D&x-amz-tagging=agent_version%3Dv1.7.1-alpha.1%26uploader_id%3D433c5166-e437-4412-9a5d-ce0edaab6d1e%26vendor%3Dk8s%26checksum_sha256%3D9fc86da194d33a32764e81226000496547df6607c1445c5ce297d3c59ffcfcc1%26upload_type%3Dk8s_snapshot%26tenant_id%3D8f08a102-58ca-49cd-960e-debc5e0d3cd4%26username%3Dgithub-jetstack-secure-tests%40cyberark.cloud.420375&x-amz-server-side-encryption=AES256&x-amz-checksum-sha256=9fc86da194d33a32764e81226000496547df6607c1445c5ce297d3c59ffcfcc1&x-amz-security-token=IQoJb3JpZ2luX2VjEKr%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCSVP%2FV3IvqPypLxIy8I334jSqPLEWAP2CyS%2FuMa4Rd9gIgIIidn6fdOuPwjhYBLrqxMKJdv%2Fwx00o%2FVc7DSAR9DLwqnQQIcxAAGgwxMzI4NTE5NTQyMTQiDIWN3o5QwJMjvTG9zyr6A7pNeBBSlfeAnuJTYXhqqDS2DnI5Ta5WrSnmIb6nRrCA1QtdGIoPeunsYkUX0iG97tm4cS5B1MVjvYTFHGtoIHajFuQa2NW54Hf1NR%2Fs6X0JfDN60fTKxR1Qa%2FvXOfwNa5vbNvB8sn1MP1rz6e0DEscqOJTbgHrMW2gGLU6dxL0IRqyGCk4WJLc1Y7Px8uS%2BO3x7%2Blde%2BtVsWnFchY3fQY9tETs440eWiCc3FL6NIcNGC7xxinYuB2MeXXdgNO8avLJtT15kqhX3IXKrf5MDMtwredlqqiKG9mT0LmYTVSUXap6TjJk9KD5hbLOwhpD74cEzh%2FkZTMJLgGNE4mIgxjaY%2BkKVeLg1vrJkE16ZLjRoMlM5OB4%2BxL5MCeIjrWHsDwxoKc6R3TVo1E9pjZG2dyQ1E%2FzW72XmeyU2TAh47xuJdqTp579p7GBlaRR%2FxTO68GAFSgL2Jrb%2Fu83Uqhhx424vaZbac4ax9ouWOKkn%2FsuC1lAZTKubkaPiM5Cp4F7w2rWOeTdaXyDEsDV5rQDGLtub%2BzPuENC6txz%2FUwzNzI0j8xxRknWkPyqwmwt341CuQV68yu%2F1rvaMlMhpEL2pcd8NHQJCEpJtmzjHREHgD%2BLcy55MUN6nprfjMtQ7E1klVpBQ1y7stirS9IbxIO3INLpYxnmfJl4AM98OMLGMp8gGOp0BQeddFUJo%2B0x1pQ9e4rCYRUBSNvnisfFR1UQXez7J7NloB4gVSoNWEUuq8iY2h8SbiviBIP%2BczJUm%2B4%2Fv5%2BGdvmMAQetiMOfgkCcHxr1q%2FCi7HGasdqitXDpxAihthGFu4p8EEQMaYzaUaWEDRneSLzSBJyiRZGSZfV66AnPYevjGrcGy67BwuwY0ywRgWGN%2FhOz1AiEKA6qRIwzkvQ%3D%3D&Expires=1762248547",
"status": "200 OK",
"duration": "1.285922419s"
}
{
"ts": 1762248249174.4807,
"caller": "transport/round_trippers.go:632",
"msg": "Response",
"v": 6,
"logger": "Run.gatherAndOutputData.postData",
"verb": "PUT",
"url": "https://snapshots-marshmallow-a1b2c3d4-integration.s3.amazonaws.com/k8s_snapshot/8f08a102-58ca-49cd-960e-debc5e0d3cd4/433c5166-e437-4412-9a5d-ce0edaab6d1e/20251104_092407_764.snapshot?AWSAccessKeyId=ASIAR53UX6ITKF3E45BC&Signature=tReq4nOu%2BUYUtMwlE%2BkY%2FnuDoZk%3D&x-amz-tagging=agent_version%3Dv1.7.1-alpha.1%26uploader_id%3D433c5166-e437-4412-9a5d-ce0edaab6d1e%26vendor%3Dk8s%26checksum_sha256%3D9fc86da194d33a32764e81226000496547df6607c1445c5ce297d3c59ffcfcc1%26upload_type%3Dk8s_snapshot%26tenant_id%3D8f08a102-58ca-49cd-960e-debc5e0d3cd4%26username%3Dgithub-jetstack-secure-tests%40cyberark.cloud.420375&x-amz-server-side-encryption=AES256&x-amz-checksum-sha256=9fc86da194d33a32764e81226000496547df6607c1445c5ce297d3c59ffcfcc1&x-amz-security-token=IQoJb3JpZ2luX2VjEKr%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCSVP%2FV3IvqPypLxIy8I334jSqPLEWAP2CyS%2FuMa4Rd9gIgIIidn6fdOuPwjhYBLrqxMKJdv%2Fwx00o%2FVc7DSAR9DLwqnQQIcxAAGgwxMzI4NTE5NTQyMTQiDIWN3o5QwJMjvTG9zyr6A7pNeBBSlfeAnuJTYXhqqDS2DnI5Ta5WrSnmIb6nRrCA1QtdGIoPeunsYkUX0iG97tm4cS5B1MVjvYTFHGtoIHajFuQa2NW54Hf1NR%2Fs6X0JfDN60fTKxR1Qa%2FvXOfwNa5vbNvB8sn1MP1rz6e0DEscqOJTbgHrMW2gGLU6dxL0IRqyGCk4WJLc1Y7Px8uS%2BO3x7%2Blde%2BtVsWnFchY3fQY9tETs440eWiCc3FL6NIcNGC7xxinYuB2MeXXdgNO8avLJtT15kqhX3IXKrf5MDMtwredlqqiKG9mT0LmYTVSUXap6TjJk9KD5hbLOwhpD74cEzh%2FkZTMJLgGNE4mIgxjaY%2BkKVeLg1vrJkE16ZLjRoMlM5OB4%2BxL5MCeIjrWHsDwxoKc6R3TVo1E9pjZG2dyQ1E%2FzW72XmeyU2TAh47xuJdqTp579p7GBlaRR%2FxTO68GAFSgL2Jrb%2Fu83Uqhhx424vaZbac4ax9ouWOKkn%2FsuC1lAZTKubkaPiM5Cp4F7w2rWOeTdaXyDEsDV5rQDGLtub%2BzPuENC6txz%2FUwzNzI0j8xxRknWkPyqwmwt341CuQV68yu%2F1rvaMlMhpEL2pcd8NHQJCEpJtmzjHREHgD%2BLcy55MUN6nprfjMtQ7E1klVpBQ1y7stirS9IbxIO3INLpYxnmfJl4AM98OMLGMp8gGOp0BQeddFUJo%2B0x1pQ9e4rCYRUBSNvnisfFR1UQXez7J7NloB4gVSoNWEUuq8iY2h8SbiviBIP%2BczJUm%2B4%2Fv5%2BGdvmMAQetiMOfgkCcHxr1q%2FCi7HGasdqitXDpxAihthGFu4p8EEQMaYzaUaWEDRneSLzSBJyiRZGSZfV66AnPYevjGrcGy67BwuwY0ywRgWGN%2FhOz1AiEKA6qRIwzkvQ%3D%3D&Expires=1762248547",
"s
After
{
"ts": 1762248834529.288,
"caller": "http_client/roundtripper_log.go:40",
"msg": "outgoing http request succeeded",
"v": 6,
"logger": "Run.gatherAndOutputData.postData",
"method": "POST",
"uri": "https://tlskp-test.inventory.integration-cyberark.cloud/api/ingestions/kubernetes/snapshot-links",
"status": "200 OK",
"duration": "1.603234558s"
}
{
"ts": 1762248835677.9707,
"caller": "http_client/roundtripper_log.go:40",
"msg": "outgoing http request succeeded",
"v": 6,
"logger": "Run.gatherAndOutputData.postData",
"method": "PUT",
"uri": "https://snapshots-marshmallow-a1b2c3d4-integration.s3.amazonaws.com/k8s_snapshot/8f08a102-58ca-49cd-960e-debc5e0d3cd4/433c5166-e437-4412-9a5d-ce0edaab6d1e/20251104_093354_378.snapshot?AWSAccessKeyId=ASIAR53UX6ITKF3E45BC&Signature=RhKUEBYCZg6aMtc%2FI0zcjeKluBo%3D&x-amz-tagging=agent_version%3Dv1.7.1-alpha.1-dirty%26uploader_id%3D433c5166-e437-4412-9a5d-ce0edaab6d1e%26vendor%3Dk8s%26checksum_sha256%3D9d4de60495c11af383f0f0d14a9d4ae6673b929562e0050f03ddff107b50759f%26upload_type%3Dk8s_snapshot%26tenant_id%3D8f08a102-58ca-49cd-960e-debc5e0d3cd4%26username%3Dgithub-jetstack-secure-tests%40cyberark.cloud.420375&x-amz-server-side-encryption=AES256&x-amz-checksum-sha256=9d4de60495c11af383f0f0d14a9d4ae6673b929562e0050f03ddff107b50759f&x-amz-security-token=IQoJb3JpZ2luX2VjEKr%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCSVP%2FV3IvqPypLxIy8I334jSqPLEWAP2CyS%2FuMa4Rd9gIgIIidn6fdOuPwjhYBLrqxMKJdv%2Fwx00o%2FVc7DSAR9DLwqnQQIcxAAGgwxMzI4NTE5NTQyMTQiDIWN3o5QwJMjvTG9zyr6A7pNeBBSlfeAnuJTYXhqqDS2DnI5Ta5WrSnmIb6nRrCA1QtdGIoPeunsYkUX0iG97tm4cS5B1MVjvYTFHGtoIHajFuQa2NW54Hf1NR%2Fs6X0JfDN60fTKxR1Qa%2FvXOfwNa5vbNvB8sn1MP1rz6e0DEscqOJTbgHrMW2gGLU6dxL0IRqyGCk4WJLc1Y7Px8uS%2BO3x7%2Blde%2BtVsWnFchY3fQY9tETs440eWiCc3FL6NIcNGC7xxinYuB2MeXXdgNO8avLJtT15kqhX3IXKrf5MDMtwredlqqiKG9mT0LmYTVSUXap6TjJk9KD5hbLOwhpD74cEzh%2FkZTMJLgGNE4mIgxjaY%2BkKVeLg1vrJkE16ZLjRoMlM5OB4%2BxL5MCeIjrWHsDwxoKc6R3TVo1E9pjZG2dyQ1E%2FzW72XmeyU2TAh47xuJdqTp579p7GBlaRR%2FxTO68GAFSgL2Jrb%2Fu83Uqhhx424vaZbac4ax9ouWOKkn%2FsuC1lAZTKubkaPiM5Cp4F7w2rWOeTdaXyDEsDV5rQDGLtub%2BzPuENC6txz%2FUwzNzI0j8xxRknWkPyqwmwt341CuQV68yu%2F1rvaMlMhpEL2pcd8NHQJCEpJtmzjHREHgD%2BLcy55MUN6nprfjMtQ7E1klVpBQ1y7stirS9IbxIO3INLpYxnmfJl4AM98OMLGMp8gGOp0BQeddFUJo%2B0x1pQ9e4rCYRUBSNvnisfFR1UQXez7J7NloB4gVSoNWEUuq8iY2h8SbiviBIP%2BczJUm%2B4%2Fv5%2BGdvmMAQetiMOfgkCcHxr1q%2FCi7HGasdqitXDpxAihthGFu4p8EEQMaYzaUaWEDRneSLzSBJyiRZGSZfV66AnPYevjGrcGy67BwuwY0ywRgWGN%2FhOz1AiEKA6qRIwzkvQ%3D%3D&Expires=1762249134",
"status": "200 OK",
"duration": "1.148032927s"
}
Because venafi-connection-lib 0.5.1 includes the debugging roundtripper as part of the default client. Added debug logging to the ark-test-e2e so that I can see the debug logging still working. - Remove debug roundtripper from agent HTTP client - Drop import of k8s.io/client-go/transport - Enable verbose logging in e2e helm chart (set --log-level=6) Signed-off-by: Richard Wall <[email protected]>
wallrj-cyberark
force-pushed
the
go-mod-upgrade
branch
from
e0d73d1 to
5ed7115
Compare
wallrj-cyberark
commented
Nov 4, 2025
|
|
||
| var rootCAs *x509.CertPool | ||
| httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs) | ||
| httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext) |
Member
Author
There was a problem hiding this comment.
$ go test ./internal/cyberark \
-v -count 1 -run TestCyberArkClient_PutSnapshot_RealAPI -args -testing.v 6
=== RUN TestCyberArkClient_PutSnapshot_RealAPI
roundtripper_log.go:40: I1104 09:43:58.104363] outgoing http request succeeded method="GET" uri="https://platform-discovery.integration-cyberark.cloud/api/public/tenant-discovery?bySubdomain=tlskp-test" status="200 OK" duration="439.180656ms"
roundtripper_log.go:40: I1104 09:43:58.527323] outgoing http request succeeded method="POST" uri="https://anb5751.id.integration-cyberark.cloud/Security/StartAuthentication" status="200 OK" duration="421.741304ms"
identity.go:293: I1104 09:43:58.527736] made successful request to StartAuthentication source="Identity.doStartAuthentication" summary="NewPackage"
roundtripper_log.go:40: I1104 09:43:58.905334] outgoing http request succeeded method="POST" uri="https://anb5751.id.integration-cyberark.cloud/Security/AdvanceAuthentication" status="200 OK" duration="377.294789ms"
identity.go:403: I1104 09:43:58.920853] successfully completed AdvanceAuthentication request to CyberArk Identity; login complete username="[email protected]"
roundtripper_log.go:40: I1104 09:44:00.628463] outgoing http request succeeded method="POST" uri="https://tlskp-test.inventory.integration-cyberark.cloud/api/ingestions/kubernetes/snapshot-links" status="200 OK" duration="1.707140666s"
roundtripper_log.go:40: I1104 09:44:01.141755] outgoing http request succeeded method="PUT" uri="https://snapshots-marshmallow-a1b2c3d4-integration.s3.amazonaws.com/k8s_snapshot/8f08a102-58ca-49cd-960e-debc5e0d3cd4/bb068932-c80d-460d-88df-34bc7f3f3297/20251104_094400_256.snapshot?AWSAccessKeyId=ASIAR53UX6ITCSUYRTBR&Signature=ugXxaXWwjQzHC5pvjY4FTNUuSCE%3D&x-amz-tagging=agent_version%3Ddevelopment%26uploader_id%3Dbb068932-c80d-460d-88df-34bc7f3f3297%26vendor%3Dk8s%26checksum_sha256%3Df421a5b3ed6215195888f6ba3747feeeb4fd9ee70e9a097ffb83b0df2a4f5d8e%26upload_type%3Dk8s_snapshot%26tenant_id%3D8f08a102-58ca-49cd-960e-debc5e0d3cd4%26username%3Dgithub-jetstack-secure-tests%40cyberark.cloud.420375&x-amz-server-side-encryption=AES256&x-amz-checksum-sha256=f421a5b3ed6215195888f6ba3747feeeb4fd9ee70e9a097ffb83b0df2a4f5d8e&x-amz-security-token=IQoJb3JpZ2luX2VjEKr%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCICXYQy3cD%2FaLhWG2KasQiqJCHM3vJVZ3tcRGGO0wMdYTAiEA7v5IW7I49DSy5FR6ecbeTC9oN7Hd2sMvHZ8d%2F5ny8CcqnQQIcxAAGgwxMzI4NTE5NTQyMTQiDDeSwcjRik9kM7zOXyr6A3MV5Scf7ayA6P3rnQn0mIdZ9dFhwD%2BjMblTdbf3z23%2BzpXVQwrsdBvXTvt0Vz72pZUs0Wxhf0kRjvObF6UHMI9MRi9zBHc0y%2F%2BzAZAO42xFSXAE%2BQUTHx2NwHJpNGlVbQTvGoVO5941%2FQDfmwctNRFKHsUP71KFSmOiopQQ2lyvvPtWmBoJM21Z1xShg5siU%2FfaMOY8c4LhDy7Sf50L2CiqR0GIe0NzAROSwnm7WtAe%2FFGgVHvTHAMWgWDYcGCiwTNyQcr%2FQYLtzYop6y84xMTQY4SsSXMhiyBByHeW2WQGIes%2B14AcnEBUVRrV7qmH5vTnkoNep%2BHz5gOKNjUO2cornEKR7tIpbxgeAAlmx1N6%2Bfa08OMcvWljKyOqGbMFF2IiKTHm1CS1ZEM%2FdINcUdDMtXvh4JqxUTKt9zdWu1AIyX02exxEF16A%2FS92vASmetb06eFcpcWS5dpheCMxjG2zXmqBGaBxXzBbHxQOQHqPiSI8SLJFDK54NtOTluW7kyr5WV6oGezJ5fWRgCGAtu0MpmyzmOrCpun6rTFf1M7dbUdN5hjY2xTinyPdsHOHHgy1lYyvKmvlrCCP7EnPk3CroYR7meui%2FQg10W88%2BZzmwPuTZWEyuZpFeYQ%2Fx7q9%2B5J%2FThRY4pdoGNPIrUozJxUG02dVkXdk97IGMOCVp8gGOp0BBfiZuFBYnKOTHbIBEn1WlBSRt%2BI77Ud49cb0ozwWoGcU0OKCVTlTTaZq%2FBFWPapELQoZduK2n%2BOxG8FHjuxQ9cYzOWoVGclYMfHT2K2j14dc%2Fj86byelq9IAQpuDVlAKirolcErIdNHLQZK6tiT%2FEzd9Uq872ucqjpfXTuSxrLd%2F56UhVWCTNPTnMkCknphdsmtow8HESfP7%2F1ic4A%3D%3D&Expires=1762249740" status="200 OK" duration="512.609881ms"
--- PASS: TestCyberArkClient_PutSnapshot_RealAPI (3.48s)
PASS
ok github.com/jetstack/preflight/internal/cyberark 3.583s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
venafi-connection-lib v0.5.1 contains some extra debug logging which will help diagnose some customer reported issues.
Part of VC-46449
Testing
I added the
test-e2elabel to trigger the automated GKE end-to-end test and that passed.Also created a test release so that others can verify that the expected debug logs are now generated by venaf-kubernetes-agent.