Skip to content

Conversation

@mavriq
Copy link

@mavriq mavriq commented Nov 8, 2025

What this PR does / why we need it:

This PR enhances the ingress-nginx balancer functionality by adding support for multiple alternative backends.
Currently, the balancer can only use one alternative backend, but this change allows defining multiple alternative backends and selecting the first suitable one based on request context.

Types of changes

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Updated existing unit tests in balancer_test.lua to cover the new functionality
  • Added comprehensive tests for multiple alternative backends scenarios
  • Verified that all existing tests pass with the modified implementation
  • Tested various scenarios including canary deployments with cookies, headers, and weights

Checklist:

  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

Key Changes:

  • Replaced route_to_alternative_balancer with is_alternative_backend_suitable and get_alternative_or_original_balancer
  • Added support for multiple alternative backends in alternative_backends list
  • Maintained backward compatibility with existing configurations
  • Simplified the get_balancer function logic

@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 65c8a5f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/690f9b6cc0f912000866f41c

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested a review from cpanato November 8, 2025 19:25
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/lua Issues or PRs related to lua code labels Nov 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Gacko November 8, 2025 19:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mavriq
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @mavriq!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mavriq. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 8, 2025
@mavriq mavriq changed the title Draft: adding support for traffic shaping for more than one alternative backends Adding support for traffic shaping for more than one alternative backends Nov 8, 2025
@Gacko Gacko removed request for Gacko and cpanato November 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants