-
Notifications
You must be signed in to change notification settings - Fork 15.1k
add note for cgroup v1 deprecation during kubelet upgrade #53082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-1.35
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -241,6 +241,16 @@ kubectl drain <node-to-drain> --ignore-daemonsets | |||||||
|
|
||||||||
| ### Upgrade kubelet and kubectl | ||||||||
|
|
||||||||
| {{< note >}} | ||||||||
| FailCgroupV1 is a kubelet configuration option that is set to 'true' by default. | ||||||||
| If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| The cgroups v1 support is deprecated and will be removed in a future release. | ||||||||
| If you are using cgroups v1, you should migrate to cgroups v2. | ||||||||
| To explicitly enable cgroups v1 support for kubelet v1.35 or newer, | ||||||||
| you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| For more information, see https://git.k8s.io/enhancements/keps/sig-node/5573-remove-cgroup-v1. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should link to the docs about the deprecation, not to the KEP. |
||||||||
| {{</ note >}} | ||||||||
|
|
||||||||
| 1. Upgrade the kubelet and kubectl: | ||||||||
|
|
||||||||
| {{< tabs name="k8s_install_kubelet" >}} | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -75,6 +75,16 @@ kubectl drain <node-to-drain> --ignore-daemonsets | |||||||
|
|
||||||||
| ### Upgrade kubelet and kubectl | ||||||||
|
|
||||||||
| {{< note >}} | ||||||||
| FailCgroupV1 is a kubelet configuration option that is set to 'true' by default since v1.35. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Style and wording nit:
Suggested change
|
||||||||
| If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set.. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| The cgroups v1 support is deprecated and will be removed in a future release. | ||||||||
| If you are using cgroups v1, you should migrate to cgroups v2. | ||||||||
| To explicitly enable cgroups v1 support for kubelet v1.35 or newer, | ||||||||
| you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| For more information, see https://git.k8s.io/enhancements/keps/sig-node/5573-remove-cgroup-v1. | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should link to the docs about the deprecation, not to the KEP. |
||||||||
| {{</ note >}} | ||||||||
|
|
||||||||
| 1. Upgrade the kubelet and kubectl: | ||||||||
|
|
||||||||
| {{< tabs name="k8s_kubelet_and_kubectl" >}} | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style and wording nit: