Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,16 @@ kubectl drain <node-to-drain> --ignore-daemonsets

### Upgrade kubelet and kubectl

{{< note >}}
FailCgroupV1 is a kubelet configuration option that is set to 'true' by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style and wording nit:

Suggested change
FailCgroupV1 is a kubelet configuration option that is set to 'true' by default.
On Linux nodes, the kubelet defaults to supporting only cgroups v2.
For Kubernetes {{< skew currentVersion >}} the `FailCgroupV1` kubelet configuration option is set to true by default.

If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set.
If you are using cgroups v1 and the `FailCgroupV1` setting is not set to true,
the kubelet reports an error and fails to start.

The cgroups v1 support is deprecated and will be removed in a future release.
If you are using cgroups v1, you should migrate to cgroups v2.
To explicitly enable cgroups v1 support for kubelet v1.35 or newer,
you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation.
you **must** set the kubelet configuration option `FailCgroupV1` to false. You must also explicitly skip this kubeadm validation.

For more information, see https://git.k8s.io/enhancements/keps/sig-node/5573-remove-cgroup-v1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the docs about the deprecation, not to the KEP.

{{</ note >}}

1. Upgrade the kubelet and kubectl:

{{< tabs name="k8s_install_kubelet" >}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ kubectl drain <node-to-drain> --ignore-daemonsets

### Upgrade kubelet and kubectl

{{< note >}}
FailCgroupV1 is a kubelet configuration option that is set to 'true' by default since v1.35.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style and wording nit:

Suggested change
FailCgroupV1 is a kubelet configuration option that is set to 'true' by default since v1.35.
On Linux nodes, the kubelet defaults to supporting only cgroups v2.
For Kubernetes {{< skew currentVersion >}} the `FailCgroupV1` kubelet configuration option is set to true by default.

If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are using cgroups v1, kubelet will fail to start if the FailCgroupV1 is not set..
If you are using cgroups v1 and the `FailCgroupV1` setting is not set to true,
the kubelet reports an error and fails to start.

The cgroups v1 support is deprecated and will be removed in a future release.
If you are using cgroups v1, you should migrate to cgroups v2.
To explicitly enable cgroups v1 support for kubelet v1.35 or newer,
you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you must set the kubelet configuration option 'FailCgroupV1' to 'false'. You must also explicitly skip this validation.
you **must** set the kubelet configuration option `FailCgroupV1` to false. You must also explicitly skip this kubeadm validation.

For more information, see https://git.k8s.io/enhancements/keps/sig-node/5573-remove-cgroup-v1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the docs about the deprecation, not to the KEP.

{{</ note >}}

1. Upgrade the kubelet and kubectl:

{{< tabs name="k8s_kubelet_and_kubectl" >}}
Expand Down