Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Conversation

@acquamarin
Copy link
Contributor

This PR implements the extension signature check mechanism in kuzu.
By default, kuzu verifies the extension signature and only loads extensions with correct signature.
extension signature verification can be disabled by setting ALLOW_UNSIGNED_EXTENSION to false.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (bbb02f3) to head (0369b18).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/extension/extension_manager.cpp 0.00% 33 Missing ⚠️
src/include/main/settings.h 0.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5945      +/-   ##
==========================================
+ Coverage   85.79%   86.22%   +0.42%     
==========================================
  Files        1632     1449     -183     
  Lines       74969    65283    -9686     
  Branches     8936     7970     -966     
==========================================
- Hits        64321    56288    -8033     
+ Misses      10397     8743    -1654     
- Partials      251      252       +1     
Flag Coverage Δ
extension ?
in-mem 81.10% <0.00%> (-0.14%) ⬇️
on-disk 86.29% <0.00%> (-0.05%) ⬇️
recovery 86.29% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Benchmark Result

Master commit hash: 5b78870eaacadd1830368de7879d494e17fd2267
Branch commit hash: a5383745c75530eed98077a165efc5f10f797cc6

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
join SelectiveTwoHopJoin 61.12 50.02 11.10 (22.19%)
multi-rel multi-rel-large-scan 1755.24 1438.88 316.37 (21.99%)
recursive_join recursive-join-sparse 10.14 6.75 3.38 (50.09%)
Other queries
Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 701.56 709.30 -7.75 (-1.09%)
aggregation q28 7722.07 7775.64 -53.57 (-0.69%)
filter q14 60.78 59.27 1.50 (2.54%)
filter q15 60.24 59.41 0.83 (1.40%)
filter q16 277.59 278.46 -0.87 (-0.31%)
filter q17 380.34 380.96 -0.62 (-0.16%)
filter q18 1870.75 1844.67 26.09 (1.41%)
filter zonemap-node 23.27 23.25 0.02 (0.10%)
filter zonemap-node-lhs-cast 23.55 23.65 -0.11 (-0.45%)
filter zonemap-node-null 23.17 23.26 -0.09 (-0.40%)
filter zonemap-rel 5423.68 5443.00 -19.33 (-0.36%)
fixed_size_expr_evaluator q07 623.54 627.20 -3.66 (-0.58%)
fixed_size_expr_evaluator q08 906.62 912.12 -5.51 (-0.60%)
fixed_size_expr_evaluator q09 905.04 914.58 -9.54 (-1.04%)
fixed_size_expr_evaluator q10 190.58 196.94 -6.37 (-3.23%)
fixed_size_expr_evaluator q11 192.28 198.32 -6.04 (-3.05%)
fixed_size_expr_evaluator q12 167.94 176.11 -8.17 (-4.64%)
fixed_size_expr_evaluator q13 1501.63 1512.92 -11.29 (-0.75%)
fixed_size_seq_scan q23 49.64 57.18 -7.54 (-13.18%)
join q29 853.17 781.57 71.60 (9.16%)
join q30 1749.67 1792.81 -43.14 (-2.41%)
join q31 7.17 6.78 0.39 (5.71%)
ldbc_snb_ic q35 8.61 9.31 -0.70 (-7.53%)
ldbc_snb_ic q36 95.13 100.96 -5.83 (-5.78%)
ldbc_snb_is q32 5.20 5.23 -0.02 (-0.48%)
ldbc_snb_is q33 14.47 17.66 -3.19 (-18.07%)
ldbc_snb_is q34 1.33 1.11 0.22 (19.77%)
limit push-down-limit-into-distinct 1903.89 1955.86 -51.97 (-2.66%)
multi-rel multi-rel-lookup 11.44 10.88 0.57 (5.21%)
multi-rel multi-rel-small-scan 210.60 200.49 10.11 (5.04%)
order_by q25 64.29 71.29 -7.00 (-9.82%)
order_by q26 382.07 396.09 -14.02 (-3.54%)
order_by q27 1290.01 1314.96 -24.95 (-1.90%)
recursive_join recursive-join-bidirection 301.19 295.43 5.76 (1.95%)
recursive_join recursive-join-dense 7086.24 7016.23 70.01 (1.00%)
recursive_join recursive-join-path 23756.58 23663.39 93.19 (0.39%)
recursive_join recursive-join-trail 7041.38 6928.63 112.74 (1.63%)
scan_after_filter q01 102.98 102.23 0.75 (0.74%)
scan_after_filter q02 89.42 89.96 -0.54 (-0.61%)
shortest_path_ldbc100 q37 80.05 71.98 8.07 (11.21%)
shortest_path_ldbc100 q38 307.92 302.42 5.50 (1.82%)
shortest_path_ldbc100 q39 87.78 85.76 2.02 (2.36%)
shortest_path_ldbc100 q40 502.36 516.88 -14.52 (-2.81%)
var_size_expr_evaluator q03 2125.45 2126.72 -1.27 (-0.06%)
var_size_expr_evaluator q04 2164.16 2130.49 33.67 (1.58%)
var_size_expr_evaluator q05 2548.31 2613.34 -65.03 (-2.49%)
var_size_expr_evaluator q06 1281.66 1261.52 20.13 (1.60%)
var_size_seq_scan q19 1359.33 1375.64 -16.32 (-1.19%)
var_size_seq_scan q20 2529.84 2578.91 -49.07 (-1.90%)
var_size_seq_scan q21 2144.62 2180.88 -36.26 (-1.66%)
var_size_seq_scan q22 111.47 108.62 2.85 (2.62%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants