Skip to content

Conversation

@cuisongliu
Copy link
Collaborator

No description provided.

@cuisongliu cuisongliu requested a review from a team as a code owner October 15, 2025 07:40
@cuisongliu cuisongliu added this to the v5.1 milestone Oct 15, 2025
@chatgpt-codex-connector
Copy link

💡 Codex Review

cloud-release:
uses: ./.github/workflows/cloud-release.yml
needs:
- releaser
permissions:
contents: read
packages: write
secrets: inherit
with:
tag: ${{ github.ref_name }}
build_offline_tar_only: false

P0 Badge Ensure cloud-release workflow supports workflow_call

The new cloud-release job references .github/workflows/cloud-release.yml as a reusable workflow, but cloud-release.yml only declares on: workflow_dispatch and lacks a workflow_call trigger. GitHub rejects jobs that uses: a workflow without workflow_call, so any tag push will fail to run the release pipeline before the first step executes. Either keep the script-based dispatch or add a workflow_call entry (with the required inputs) to the called workflow.


needs:
- releaser
permissions:
contents: read
packages: write

P1 Badge Restore actions:write permission for cloud release

When converting cloud-release to a reusable workflow, the job permissions were reduced to contents: read and packages: write. The called workflow uses github.rest.actions.createWorkflowDispatch to trigger child workflows and therefore needs actions: write; without it, those API calls will return 403 even if the workflow is callable. Add the actions: write scope back to match the previous configuration.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@cuisongliu
Copy link
Collaborator Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@labring labring deleted a comment from chatgpt-codex-connector bot Oct 15, 2025
@cuisongliu
Copy link
Collaborator Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@cuisongliu
Copy link
Collaborator Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Copy link
Member

@zijiren233 zijiren233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow create in .github/workflows/cloud-release.yml needs to be switched to use workflow.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.86%. Comparing base (9c07d8a) to head (4af4035).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6093   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files           8        8           
  Lines         653      653           
=======================================
  Hits          404      404           
  Misses        202      202           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuisongliu cuisongliu merged commit 4b58b9e into labring:main Oct 15, 2025
77 checks passed
@cuisongliu cuisongliu deleted the fix-tag branch October 15, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants