Skip to content

Conversation

@CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 13, 2025

Description

This pull request made the following changes:

  • Removed Andy Towne and Favour Chibueze

  • Added a honor roll section at the bottom of the page so we can show past members.

  • Add Simran Sethi & Adrian Schimpf

Linked issue

Closes #92

Screenshots or screen recordings

Before

before the update

After

update

@CBID2 CBID2 requested a review from a team as a code owner October 13, 2025 18:36
@CBID2 CBID2 requested review from adiati98 and favour-chibueze and removed request for a team October 13, 2025 18:36
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 13, 2025

Hi @adiati98! :) I made the pull request

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 13, 2025

Hi @adiati98! :) I made the pull request! :)

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @CBID2 ✨️

I believe the issue only mentioned changing the Council page and not the community leadership one.

Can you please address this? Let us know if you have any questions! 🙂

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 14, 2025

Thanks for the PR, @CBID2 ✨️

I believe the issue only mentioned changing the Council page and not the community leadership one.

Can you please address this? Let us know if you have any questions! 🙂

Hi @adiati98. After rereading, I realized that it was the council section that I was supposed to work on my mistake 😔

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 16, 2025

I made the changes @adiati98

@CBID2 CBID2 requested a review from adiati98 October 16, 2025 19:58
Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 thank you for the fix!
I also left some comments here.


@RCheesley I also need your review on this. Thanks! ✨

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CBID2 I don't quite understand what's happening here. Why are you creating a docs.md file in the pages directory? We don't use that format or location any more, we use .rst files in the /docs folder.

This PR should only be updating the Council members, there shouldn't be any need to add or recreate the Council page.

Perhaps you could talk me through what the intention is here? If you didn't mean to create that file, please delete it from this PR and push the commit, which should then leave us just with the changes to the community_leadership.rst file.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 25, 2025

Hi @CBID2 I don't quite understand what's happening here. Why are you creating a docs.md file in the pages directory? We don't use that format or location any more, we use .rst files in the /docs folder.

This PR should only be updating the Council members, there shouldn't be any need to add or recreate the Council page.

Perhaps you could talk me through what the intention is here? If you didn't mean to create that file, please delete it from this PR and push the commit, which should then leave us just with the changes to the community_leadership.rst file.

I was addressing this part in the issue @RCheesley

"As we're in the process of moving to Read the Docs and this page has already been migrated over, please update in the Markdown format here:

https://github.com/mautic/mautic-community-handbook/blob/main/pages/04.community-leadership/03.community-council/docs.md

and also the RST format"
So I made the changes in the Markdown version.

@RCheesley
Copy link
Member

Ahhh, sorry that is a very old comment - we've now completely transitioned to Read the Docs so this extra page is no longer needed, so it's safe to remove the file.

This file was a duplicate of the content in docs/community_leadership/community_council.rst.
Maintaining a single source of truth in the RST format is preferred.

Refs: mautic#408
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 25, 2025

Ahhh, sorry that is a very old comment - we've now completely transitioned to Read the Docs so this extra page is no longer needed, so it's safe to remove the file.

Done @RCheesley

@CBID2 CBID2 requested a review from RCheesley October 25, 2025 22:24
Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 can you please re-check the issue requirements? Especially below info:

We need to make some updates to the Council page on the Community Handbook.

Please add a honor roll section at the bottom of the page so we can show past members.

I believe what @RCheesley meant here is:

  1. We want to make updates to the Council section
  2. Add a honor roll section to the Council section, as we want to make updates to this section.

What you did here is adding the names to the Leadership Honor Roll, and not adding a new Honor Roll section for the Mautic Council section.


@RCheesley please confirm if the above info is going to the right direction.

Also, do you want to only remove Andy Towne and Favour Chibueze, or move them as well to the honor role?

Thanks! ✨

@RCheesley
Copy link
Member

Yes that's right @adiati98 - for the council members.

@adiati98
Copy link
Contributor

Yes that's right @adiati98 - for the council members.

Thanks you for the confirmation, @RCheesley. Another thing is do we want to only remove Andy Towne and Favour Chibueze, or move them to the Council honor role?

@RCheesley
Copy link
Member

Andy and Favour should be on the honour roll for the council, as they served a term and stepped down at the end of the term.

- Remove Andy Towne and Favour Chibueze from council
- Add Andy Towne and Favour Chibueze to honor roll
- Update current council members list

Refs: mautic#92
@CBID2
Copy link
Contributor Author

CBID2 commented Oct 29, 2025

new Honor Roll section for the Mautic Council section.

Hey @RCheesley and @adiati98, I think I got it this time.

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

I don't know what's going on here, but:

  1. The Leadership Honor Role section is missing the table.

    Image
  2. Where is the new Honor Role section for the Council as mentioned in this comment? I don't see it anywhere here.

Can you please:

  1. Test your changes locally — this is a must to see if everything works as it should,
  2. Read the requirements both in the issue and comments thoroughly. Let us know if you have questions or need help,
  3. Only tag me and @RCheesley once you're done addressing all of the feedback.

Thanks!

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 31, 2025

Hey @CBID2,

I don't know what's going on here, but:

  1. The Leadership Honor Role section is missing the table.
    Image
  2. Where is the new Honor Role section for the Council as mentioned in this comment? I don't see it anywhere here.

Can you please:

  1. Test your changes locally — this is a must to see if everything works as it should,
  2. Read the requirements both in the issue and comments thoroughly. Let us know if you have questions or need help,
  3. Only tag me and @RCheesley once you're done addressing all of the feedback.

Thanks!

Hi @adiati98! Here's what I have so far:

screenshot

The only thing I need is to fill in the Role category for Simian and Adrian. Would "Council Members" be a good one?

@adiati98
Copy link
Contributor

adiati98 commented Oct 31, 2025

@CBID2

Please review the issue's requirement, particularly this part:

Please add a honor roll section at the bottom of the page so we can show past members.

Add:

Simran Sethi
Adrian Schimpf

It means that they're added to the Mautic Council Honor Role.

Another thing, can you please change the title from "Council Honor Role" to "Mautic Council Honor Role"? Thanks.

@RCheesley
Copy link
Member

Hi @CBID2 just checking in, are you clear on what you need to do to get this over the line? Here to help if you need a hand with anything.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 31, 2025

Hi @CBID2 just checking in, are you clear on what you need to do to get this over the line? Here to help if you need a hand with anything.

Hi @RCheesley! :) here's what I have so far

image

Should I just put "council member" in the Role category for Simian and Adrian? 🤔

@RCheesley
Copy link
Member

Yes, I'd put council member there, it's not so relevant once they leave their roles who they worked for at the time.

Thanks!

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 31, 2025

Yes, I'd put council member there, it's not so relevant once they leave their roles who they worked for at the time.

Thanks!

Ok here's what I have now @RCheesley
image
Is it good?

@RCheesley
Copy link
Member

That looks better, but I can't see it in the PR - can you push the changes so we can review? Thanks!

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 31, 2025

That looks better, but I can't see it in the PR - can you push the changes so we can review? Thanks!

Just pushed the changes @RCheesley

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBID2 - couple of changes then we'll be good to go!

- [email protected]

Mautic Council Honor Roll
========================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CBID2 did you build this locally on your machine or in a Codespace? I'm seeing a bunch of errors when I build the docs:

/var/www/html/docs/community_leadership/community_leadership.rst:263: WARNING: Title underline too short.

Mautic Council Honor Roll
======================== [docutils]
/var/www/html/docs/community_leadership/community_leadership.rst:263: WARNING: Title underline too short.

Mautic Council Honor Roll
======================== [docutils]

Please ensure that the underline is the full length of the heading otherwise you'll see these warnings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it locally

- Email Address
- Term Ended
* - Andy Towne
- Senior Customer Value Manager at Acquia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we'd agreed to change the job titles here, could we do that please? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes @RCheesley. Is it good now?

image

@RCheesley
Copy link
Member

GTG thanks @CBID2 ! 🚀

@holopin-bot
Copy link

holopin-bot bot commented Oct 31, 2025

Congratulations @CBID2, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmhf97i4e006ljo04ey7ucou6

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 31, 2025

GTG thanks @CBID2 ! 🚀

Yay! Thanks for your patience @RCheesley and @adiati98! 🤗

@RCheesley RCheesley merged commit 7d5c703 into mautic:main Oct 31, 2025
3 checks passed
@CBID2 CBID2 deleted the updating-handbook branch October 31, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Community] Update the Mautic Council page on the Community Handbook

3 participants