-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enhancement: Add feature to manually retry failed task #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mher anything I can do to help get this merged? |
sc68cal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns have been addressed, thank you for this contribution!
|
@sc68cal how can i get this merged? |
I am not the maintainer, the maintainer needs to approve and merge |
marcus-campos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
|
Thanks for the feature, @mher could we get this merged? |
|
Hi! Thanks for adding this awesome feature @yashpapa6969 ! I tested it locally and noticed a small issue: I think we need to add a route for the new controller in (r"/api/task/reapply/(.+)", tasks.TaskReapply),Otherwise the Retry button will fail with 404 |
|
@matias-martini thank you updated |
|
@yashpapa6969 Thanks for the updates! 🙌 Would you mind adding a test for the new API endpoint? It'll help ensure we cover the most common cases. |
|
@yashpapa6969 Thanks for the effort, can we have the tests to merge this? |
|
Any update on this? |
|
Would be great to see this feature merged ! |
auvipy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will also need unit tests to avoid regression
|
@yashpapa6969, thank you so much for the effort! Could you help us with the tests for it so we can review and merge? |
Change Log