Skip to content

Conversation

@yashpapa6969
Copy link

Change Log

  • API Update: Introduced the TaskReapply endpoint to reapply tasks with original arguments.
  • Error Handling: Ensures JSON-serializable arguments and robust error logging.
  • Backend Utilities: Added helper functions (parse_args, parse_kwargs, make_json_serializable) for argument parsing and serialization.

@iloveitaly
Copy link

@mher anything I can do to help get this merged?

@yashpapa6969 yashpapa6969 requested a review from sc68cal January 25, 2025 16:31
@yashpapa6969 yashpapa6969 requested a review from sc68cal January 26, 2025 14:04
Copy link

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, thank you for this contribution!

@yashpapa6969
Copy link
Author

@sc68cal how can i get this merged?

@sc68cal
Copy link

sc68cal commented Feb 2, 2025

@sc68cal how can i get this merged?

I am not the maintainer, the maintainer needs to approve and merge

Copy link

@marcus-campos marcus-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Ragnarow
Copy link

Ragnarow commented Feb 5, 2025

Thanks for the feature, @mher could we get this merged?

@matias-martini
Copy link

Hi! Thanks for adding this awesome feature @yashpapa6969 ! I tested it locally and noticed a small issue: I think we need to add a route for the new controller in flower/urls.py:

    (r"/api/task/reapply/(.+)", tasks.TaskReapply),

Otherwise the Retry button will fail with 404

@yashpapa6969
Copy link
Author

@matias-martini thank you updated

@matias-martini
Copy link

@yashpapa6969 Thanks for the updates! 🙌

Would you mind adding a test for the new API endpoint? It'll help ensure we cover the most common cases.

@Ragnarow
Copy link

@yashpapa6969 Thanks for the effort, can we have the tests to merge this?

@the-rich-piana
Copy link

Any update on this?

@alexandercarruthers
Copy link

Would be great to see this feature merged !

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will also need unit tests to avoid regression

@mihai-burduselu-ptt
Copy link

mihai-burduselu-ptt commented Sep 9, 2025

@yashpapa6969, thank you so much for the effort! Could you help us with the tests for it so we can review and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.