Update VariableRateShading.md (fix misleading sentence) #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to fix the following sentence to make it match the tables below (for some interpretations). It may actually be better to delete the entire sentence: > The mask consists of the of coverages from pixels from left-to-right, then top-to-bottom (column-major) order. First, it's definitely row-major order, not column-major. Each row of fine pixels are contiguous in the sample mask, not each column. Second, when evaluating an attribute with centroid evaluation, the definition states to use the "first covered sample". The "first" means the lowest-order bit that is set. I interpret that to mean that the "order" of the sample mask should be read as lowest-order to highest-order. Given the tables in this diagram, I would say the order is "right-to-left, then bottom-to-top (row-major)", hence this change.
jenatali
approved these changes
Jun 8, 2024
Member
jenatali
left a comment
jenatali
left a comment
There was a problem hiding this comment.
I was actually just looking at this and scratching my head this week. I believe this change is right and it makes me sad that this is the order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix the following sentence to make it match the tables below (for some interpretations). It may actually be better to delete the entire sentence:
First, it's definitely row-major order, not column-major. Each row of fine pixels are contiguous in the sample mask, not each column.
Second, when evaluating an attribute with centroid evaluation, the definition states to use the "first covered sample". The "first" means the lowest-order bit that is set. I interpret that to mean that the "order" of the sample mask should be read as lowest-order to highest-order. Given the tables in this diagram, I would say the order is "right-to-left, then bottom-to-top (row-major)", hence this change.