Document resource_group_tags parameter for Azure runbook #4101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated runbook.rst with resource_group_tags parameter description - Updated platform.rst with detailed resource_group_tags documentation - Updated azure.yml example runbook to include resource_group_tags variable - Added examples showing how to use resource_group_tags for Azure resource organization Co-authored-by: squirrelsc <[email protected]>
Address code review feedback by adding an example comment showing the expected format for resource_group_tags parameter. Co-authored-by: squirrelsc <[email protected]>
- Update example comment format to YAML style for consistency - Add Azure tag naming conventions and constraints to documentation - Specify maximum lengths and allowed characters for tags Co-authored-by: squirrelsc <[email protected]>
Use multi-line YAML format for the example comment to match documentation style and improve clarity. Co-authored-by: squirrelsc <[email protected]>
Copilot
AI
changed the title
[WIP] Add resource_group_tags to Azure runbook
Document resource_group_tags parameter for Azure runbook
Nov 7, 2025
Copilot finished work on behalf of
squirrelsc
November 7, 2025 16:41
squirrelsc
reviewed
Nov 7, 2025
squirrelsc
reviewed
Nov 7, 2025
squirrelsc
reviewed
Nov 7, 2025
- Remove Azure tag naming conventions section from platform.rst - Remove CostCenter and Owner tags from examples in platform.rst - Change resource_group_tags value from empty string to null in azure.yml - Remove Owner tag from YAML configuration example in platform.rst Co-authored-by: squirrelsc <[email protected]>
Member
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resource_group_tagsparameter was already implemented in the Azure platform but undocumented, preventing users from applying tags to resource groups created by LISA.Changes
Documentation
resource_group_tagsto Azure platform parameters list with exampleExample Runbook
resource_group_tagsvariable with null default value and multi-line YAML example commentUsage
Implementation Note
No code changes required. The parameter is defined in
AzurePlatformSchema(platform_.py:296) and properly passed tocheck_or_create_resource_group()for tag application during resource group creation.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.