Skip to content

Code QL analysis should be done on correct commit #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

Code QL analysis should be done on correct commit #6638

merged 2 commits into from
Oct 29, 2025

Conversation

@aznhassan
Copy link
Contributor

@aznhassan aznhassan commented Oct 29, 2025

Problem

At some point it was neccessary to checkout a commit two behind the current head for code analysis. This is no longer the case, and is in fact the reason all of the Code QL runs are being ignored in the Security tab.
image

Solution

  • Update the CodeQL yml to run the analysis against the current commit
  • Limit CodeQL runs to important branches, and on pushes against the master branch

@aznhassan aznhassan requested a review from a team October 29, 2025 22:39
@aznhassan aznhassan self-assigned this Oct 29, 2025
riknoll
riknoll approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@riknoll riknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

@aznhassan aznhassan merged commit f35da3e into master Oct 29, 2025
19 checks passed
@aznhassan aznhassan deleted the aznhassan/codeql branch October 29, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riknoll riknoll riknoll approved these changes

Assignees

@aznhassan aznhassan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aznhassan @riknoll