Remove dead code #1879
Merged
Remove dead code #1879
+0
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed deleting this when moving subagents to core
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the SubagentToolCallingLoop class and its interface, which appears to be dead code that is no longer referenced anywhere in the codebase. The subagent functionality is now handled through the DefaultIntentRequestHandler class via the isSubagent flag on ChatRequest.
Key Changes
- Deleted the entire
subagentLoop.tsfile containingSubagentToolCallingLoopclass andISubagentToolCallingLoopOptionsinterface
lszomoru
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed deleting this when moving subagents to core