[WIP] Review copilotcli session service code

[Copilot]

Code Review: copilotcliSessionService.ts

Issues Identified

High Priority

• Fix potential race condition in getAllSessions with cached promise
• Fix memory leak risk in session terminator disposal
• Improve error handling in deleteSession method
• Fix potential null reference in getReadonlySdkSession

Medium Priority

• Add proper TypeScript type annotations (avoid any)
• Improve session label generation edge cases
• Add validation for sessionId parameters
• Improve logging consistency

Low Priority

• Add JSDoc comments for public methods
• Simplify complex conditional logic
• Consider extracting magic numbers to constants

Code Quality

• Review and test all identified issues
• Ensure all changes are minimal and surgical
• Run tests to validate changes

Original prompt

I want you to review #file:copilotcliSessionService.ts

Created from VS Code via the GitHub Pull Request extension.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.