Update katex regex for jQuery expressions in KaTeX matching #269635
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikdmello
changed the title
Collaborator
|
Seems like some of the katex tests are failing in the check. @nikdmello Can you please take a look |
auto-merge was automatically disabled
November 6, 2025 06:58
Head branch was pushed to by a user without write access
nikdmello
force-pushed
the
fix/katex-jquery-expressions
branch
from
02fbdaf to
c646e63
Compare
Contributor
Author
|
@mjbvz I've added the missing snapshot that was causing the tests to fail |
mjbvz
previously approved these changes
Nov 7, 2025
auto-merge was automatically disabled
November 7, 2025 22:51
Head branch was pushed to by a user without write access
Contributor
Author
|
@mjbvz I've updated the snapshot to match the actual output |
TylerLeonhardt
approved these changes
Nov 8, 2025
bpasero
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates katex regex coverage for jQuery expressions with multiple dollar signs.
Ensures that when jQuery expressions like
$.getJSON, $.ajax, $.getand$("#dialogDetalleZona").dialog(...) / $("#dialogDetallePDC").dialog(...)appear on the same line, the dollar signs are not incorrectly paired as opening and closing KaTeX delimiters.Fixes #268378