-
-
Notifications
You must be signed in to change notification settings - Fork 229
[Version 3] Add linux perf functionality to cover AMD and similar #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
On my todo list:
|
|
Hello, thank you very much ! Did you write all the C code ? It use low level Linux kernel API to get power usage ? |
|
Hello @mp15 , your contribution, is very interesting, do you know if you could finish it soon ? |
2e08f20 to
cda8e69
Compare
|
Okay I've made a little progress with this. It should now not completely mess things up on non-linux systems. |
|
Hello, thanks for this contribution. I'm on Ubuntu 20.04 with an AMD CPU. I saw that normal user can read this file: What can be the problem ? |
benoit-cty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain how to test this ? It does not start on my computer (Ubuntu 22.04 on AMD GPU)
Unfortunately the kernel perf interface is restricted to processes with CAP_PERFMON or root access. |
20a4285 to
183cf8d
Compare
|
Hello @mp15, should we expect some follow up work on this PR ? Would you need some help ? |
|
Hi mp15, I saw you add AWS Graviton, does it works with your PR ? |
|
I'm sorry, I think we will have to close this PR without more information on it. @mp15 Can you help us better understand it ? |
This pull request creates an interface to linux perf through python C bindings. This allows us to measure power usage on platforms which do not support Intel RAPL but do have some machine specific registers that linux perf allows us to use to measure consumption.
This pull request is initially submitted as a draft to allow folks to have a look at the structure of the integration and make suggestions. At the moment the whole hardware measurement interface is a bit intel power gadget based and we may with to consider revising this.