Skip to content

Conversation

@bpschmitt
Copy link
Contributor

@bpschmitt bpschmitt commented Mar 20, 2025

Is this a new chart

No

What this PR does / why we need it:

Adds the ability for users to specify what container ports need to be open for both the DaemonSet and Deployment. For example, if a user wants to collect OTel internal telemetry, port 8888 needs to be open.

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

Release Notes to Publish

🚀 What's Changed

  • Adds the ability for users to specify what container ports need to be open for both the DaemonSet and Deployment. For example, if a user wants to collect OTel internal telemetry, port 8888 needs to be open.

@bpschmitt bpschmitt requested a review from a team as a code owner March 20, 2025 03:55
metrics:
enabled: true
containerPort: 8888
servicePort: 8888
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

servicePort is being ignored by the tpl function. Do we need to support this parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants