Skip to content

Conversation

@danielstokes
Copy link
Contributor

Description

add support for entity guid in the health from the health sidecar, listing them in the CR

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@danielstokes danielstokes requested a review from a team as a code owner November 6, 2025 22:06
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 26.19048% with 248 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.85%. Comparing base (e2c44c1) to head (95ea28a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta2/instrumentation_conversion.go 0.00% 110 Missing ⚠️
api/v1beta3/instrumentation_webhook.go 14.54% 92 Missing and 2 partials ⚠️
internal/instrumentation/health.go 20.00% 12 Missing ⚠️
api/v1beta3/instrumentation_types.go 52.63% 9 Missing ⚠️
api/v1beta3/image_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/name_selector.go 71.42% 4 Missing and 4 partials ⚠️
api/v1beta3/env_selector.go 75.00% 3 Missing and 3 partials ⚠️
api/v1beta3/instrumentation_conversion.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e2c44c1) and HEAD (95ea28a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (e2c44c1) HEAD (95ea28a)
7 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   68.47%   62.85%   -5.62%     
==========================================
  Files          46       52       +6     
  Lines        3454     3174     -280     
==========================================
- Hits         2365     1995     -370     
- Misses        921     1008      +87     
- Partials      168      171       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants