feat(OpAMP): adding new attributes #1811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paologallinaharbur
force-pushed
the
origin/OpAMPAttributes
branch
from
58b7e46 to
3e2fe63
Compare
vjripoll
force-pushed
the
restructure-on-host-folders
branch
2 times, most recently
from
e608a0a to
d7395b0
Compare
vjripoll
force-pushed
the
restructure-on-host-folders
branch
from
d7395b0 to
206ec88
Compare
Signed-off-by: Paolo Gallina <[email protected]>
paologallinaharbur
force-pushed
the
origin/OpAMPAttributes
branch
from
3e2fe63 to
1fcb307
Compare
Signed-off-by: Paolo Gallina <[email protected]>
paologallinaharbur
force-pushed
the
origin/OpAMPAttributes
branch
from
9ea52e2 to
d24bc30
Compare
sigilioso
reviewed
Oct 31, 2025
Signed-off-by: Paolo Gallina <[email protected]>
Signed-off-by: Paolo Gallina <[email protected]>
danielorihuela
previously approved these changes
Nov 3, 2025
sigilioso
previously approved these changes
Nov 3, 2025
| pub const CLUSTER_NAME_ATTRIBUTE_KEY: &str = "cluster.name"; | ||
| pub const HOST_ID_ATTRIBUTE_KEY: &str = opentelemetry_semantic_conventions::attribute::HOST_ID; | ||
| pub const FLEET_ID_ATTRIBUTE_KEY: &str = "fleet.guid"; | ||
| pub const OS_ATTRIBUTE_KEY: &str = "os.type"; |
Contributor
There was a problem hiding this comment.
would make sense to link to here or specify the variants to avoid miss used in the future ? https://opentelemetry.io/docs/specs/semconv/registry/attributes/os/#os-type
Member
Author
There was a problem hiding this comment.
oh I did not see that, currently I was using os::OS that instead of darwin has "macos"
Then it is better to move back to the custom constant definition I had before, no?
vjripoll
force-pushed
the
restructure-on-host-folders
branch
11 times, most recently
from
6778f0d to
6e41010
Compare
vjripoll
force-pushed
the
restructure-on-host-folders
branch
6 times, most recently
from
4b18188 to
5facfd7
Compare
vjripoll
dismissed stale reviews from sigilioso and danielorihuela
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR is introducing a new attribute for the AC only specifying the environment in which the agent is running.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
docsis aligned with the change.CONTRIBUTING.md.log level guidelines.