chore: improve const maintainability #1835
Open
+42
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsanchezgavier
commented
Nov 4, 2025
gsanchezgavier
commented
- reuse const defaults
- improves e2e test assertion time
gsanchezgavier
added
the
onhost-extended-e2e
gsanchezgavier
force-pushed
the
gsanchez/chore/improve-cli
branch
from
11790d2 to
572a18d
Compare
DavSanchez
reviewed
Nov 4, 2025
Comment on lines
+90
to
+92
| // Fleet Control auto generated agent id | ||
| pub const AGENT_ID_INFRA_AGENT: &str = "nr-infra"; | ||
| pub const AGENT_ID_NRDOT: &str = "nrdot"; |
Contributor
There was a problem hiding this comment.
We should have a way to make this robust to unilateral changes from FC (not saying it will happen, but it's the kind of thing with potential to break something in the long term xD)
Contributor
Author
There was a problem hiding this comment.
at least we have it in a const now
| ( | ||
| "license_key".to_string(), | ||
| serde_yaml::Value::String("{{NEW_RELIC_LICENSE_KEY}}".to_string()), | ||
| serde_yaml::Value::String(format!("{{{{{NEW_RELIC_LICENSE_CONFIG_KEY}}}}}")), |
Contributor
Author
There was a problem hiding this comment.
I was thinking how horrible was this while doing it but i was too lazy to check if there was a better way
agent-control/src/cli/on_host/host_monitoring_gen/otel_config_gen.rs
Outdated
Show resolved
Hide resolved
gsanchezgavier
force-pushed
the
gsanchez/chore/improve-cli
branch
from
572a18d to
bae8cf3
Compare
DavSanchez
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.