[NR-448218] convert sharedPreference to dataStore preference #391

ywang-nr · 2025-08-11T19:40:50Z

SQUASH MERGE

Ticket: https://new-relic.atlassian.net/browse/NR-448218

What's changed:

Covert sharedPreference to dataStore preference, all the data in the front-end should be the same, no UI changes.
This change requires extensive testing to make sure all the data are the same as before.
This change should resolve any ANRs related to sharedPreference, see ticket for linked tickets.
Compiled SDK needs to be upgraded from 30 to 34 for this implementation, need to re-verify if everything is fine.
Added all unit tests.
Leave session replay as is for now.
Cannot use rxjava library due to size increase of the agent, will have to redo all the dataStore code to use kotlin coroutines and Flow API --> still has size increase from 1M to 5.7M by solely adding kotlin library - this is resolved by excluding the libraries then using pom file to reference them. Referencing doc here

Additional notes:

Unit tests failing - check whether the network is connected correctly

Co-authored-by: ywang-nr <[email protected]> Co-authored-by: ywang-nr <[email protected]>

Co-authored-by: ywang-nr <[email protected]> Co-authored-by: Steve Malsam <[email protected]> Co-authored-by: ywang <[email protected]>

# Conflicts: # agent-core/src/main/java/com/newrelic/agent/android/sessionReplay/SessionReplayReporter.java # agent-core/src/main/java/com/newrelic/agent/android/sessionReplay/SessionReplaySender.java # agent/src/main/java/com/newrelic/agent/android/sessionReplay/SessionReplay.java # agent/src/main/java/com/newrelic/agent/android/sessionReplay/SessionReplayActivityLifecycleCallbacks.java # agent/src/main/java/com/newrelic/agent/android/sessionReplay/SessionReplayTextViewThingy.java # agent/src/main/java/com/newrelic/agent/android/sessionReplay/ViewDetails.java # gradle.properties

codecov · 2025-08-13T16:24:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.34%. Comparing base (c42d081) to head (1d3cf84).
⚠️ Report is 24 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #391      +/-   ##
=============================================
+ Coverage      52.35%   54.34%   +1.99%     
+ Complexity      3476     2975     -501     
=============================================
  Files            386      307      -79     
  Lines          18970    15178    -3792     
  Branches        2093     1718     -375     
=============================================
- Hits            9932     8249    -1683     
+ Misses          7963     5997    -1966     
+ Partials        1075      932     -143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cmcadams-newrelic

LGTM!

agent/src/main/java/com/newrelic/agent/android/stores/AnalyticsAttributeDataStore.java

cmcadams-newrelic · 2025-08-14T19:23:33Z

reviewing the Note section in this PR's description

Additional notes:

Draft PR for feedback, will continue polishing it

Move on to testing

Is this PR still a "Draft"? I see you included tests. so item 2 is covered.

ywang-nr · 2025-08-15T14:26:11Z

reviewing the Note section in this PR's description

Additional notes:

Draft PR for feedback, will continue polishing it

Move on to testing

Is this PR still a "Draft"? I see you included tests. so item 2 is covered.

So testing usually includes two parts.

Unit tests as much as possible.
Physical tests actually install the modified agents in application and make sure the correct data flows into NR.

cmcadams-newrelic · 2025-08-15T16:49:43Z

@ywang-nr Sorry, I did not mean to close this PR. reopened

This reverts commit a1b2c3d4.

ndesai-newrelic · 2025-08-15T19:52:21Z

these changes are increasing agent size from 1MB to 10MB, don't use rx library .

1. Debug through the process, clean up the code to make it more straightforward 2. Monitor agent behavior after

Update readme

…nter [Nr-460139] handle AnalyticsAttribute.USER_ID_ATTRIBUTE is null

#404)

…ly. (#402)

Co-authored-by: Steve Malsam <[email protected]> Co-authored-by: ywang <[email protected]> Co-authored-by: ywang-nr <[email protected]> Co-authored-by: Takahiro Menju <[email protected]>

cmcadams-newrelic and others added 6 commits July 8, 2025 11:55

feat: Update AndroidStudio setup Section in Readme (#377)

001a0b3

Feature/nr407605 sonatype migration (#381)

ad96b13

Co-authored-by: ywang-nr <[email protected]> Co-authored-by: ywang-nr <[email protected]>

[NR-426972] log reporter truncated message (#378)

61f7247

Feature/session replay organization (#384)

231a5f1

Co-authored-by: ywang-nr <[email protected]> Co-authored-by: Steve Malsam <[email protected]> Co-authored-by: ywang <[email protected]>

[NR-448218] covert sharedPreferece to dataStore preference

4e41375

ywang-nr requested review from cmcadams-newrelic and ndesai-newrelic August 11, 2025 19:41

chore: fix unit tests

054df86

cmcadams-newrelic reviewed Aug 14, 2025

View reviewed changes

agent/src/main/java/com/newrelic/agent/android/stores/AnalyticsAttributeDataStore.java Outdated Show resolved Hide resolved

cmcadams-newrelic closed this Aug 15, 2025

cmcadams-newrelic reopened this Aug 15, 2025

ndesai-newrelic changed the title ~~[NR-448218] covert sharedPreferece to dataStore preference~~ [NR-448218] convert sharedPreference to dataStore preference Aug 15, 2025

ndesai-newrelic added 2 commits August 15, 2025 14:45

Revert "Update groupId to io.github.ywang-nr"

796c5ca

This reverts commit a1b2c3d4.

Merge branch 'develop' into feature/nr448218-dataStore

c87ec92

ywang-nr and others added 10 commits August 25, 2025 11:58

chore: aar gradle file fix

0564a7f

[NR-438547] RecordMetric Investigate (#393)

c719a6e

1. Debug through the process, clean up the code to make it more straightforward 2. Monitor agent behavior after

Merge branch 'develop' into feature/nr448218-dataStore

120c77a

[NR-456281] dataStore implementation with Kotlin coroutines & Flow PAI

6056c60

feat: Includes Android Supportability Metrics (#394)

39c8ae0

feat: Updates README.md Debugging section

c5ed542

fix: Handle when setUserId receives null as a userId

12a37fa

feat: Includes Android Supportability Metrics (#394)

6bfb835

feat: Updates README.md Debugging section

5baf220

Merge pull request #400 from cmcadams-newrelic/update-readme

cd374ab

Update readme

cmcadams-newrelic and others added 13 commits September 8, 2025 14:35

Merge branch 'develop' into NR-460139-fix-null-pointer

c204289

chore: exclude libraries to avoid size increasing, unit test fix

1b479f7

Merge pull request #399 from cmcadams-newrelic/NR-460139-fix-null-poi…

c42d081

…nter [Nr-460139] handle AnalyticsAttribute.USER_ID_ATTRIBUTE is null

[NR-458555] Telemetry data transmission from the Android Agent stops … (

3e94468

#404)

NR-426877 fixes the trace listener issue which is not removed correct…

fcc8faf

…ly. (#402)

[NR-300843]Fix: OkHttp3 Url updated by interceptors (#403)

9f8fb90

Merge branch 'develop' into feature/nr448218-dataStore

653edae

[NR-456281] cleanup code, unit tests

49158db

Supportability metrics web view (#401)

0031e5b

Feature/session replay diffs (#405)

00d1849

Co-authored-by: Steve Malsam <[email protected]> Co-authored-by: ywang <[email protected]> Co-authored-by: ywang-nr <[email protected]> Co-authored-by: Takahiro Menju <[email protected]>

chore: fix unit tests

842e3d5

Merge branch 'main' into develop

2d05a64

Merge branch 'develop' into feature/nr448218-dataStore

b133c68

ndesai-newrelic force-pushed the develop branch from 2d05a64 to 7ec5755 Compare October 8, 2025 21:34

ywang-nr and others added 12 commits October 13, 2025 10:08

Merge branch 'develop' into feature/nr448218-dataStore

f3c193f

Merge branch 'develop' into feature/nr448218-dataStore

b13e957

chore: fix merging issues

a736e2d

[NR-475837] move kotlin classes, bug fixes

7ef24c3

chore: remove kotlin files under java folder

5954530

chore: cleanup code after reviewing with claude code

9417805

chore: code improvements

ab3737d

chore: add error handling and code cleanup

a7e2d98

chore: version, unit tests cleanup

a27d8e8

chore: comment out failed unit test

3751461

chore: update version and unit test fix

5c0010f

chore: version update

1d3cf84

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NR-448218] convert sharedPreference to dataStore preference #391

[NR-448218] convert sharedPreference to dataStore preference #391

Uh oh!

ywang-nr commented Aug 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

cmcadams-newrelic left a comment

Uh oh!

Uh oh!

cmcadams-newrelic commented Aug 14, 2025

Uh oh!

ywang-nr commented Aug 15, 2025

Uh oh!

cmcadams-newrelic commented Aug 15, 2025

Uh oh!

ndesai-newrelic commented Aug 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[NR-448218] convert sharedPreference to dataStore preference #391

Are you sure you want to change the base?

[NR-448218] convert sharedPreference to dataStore preference #391

Uh oh!

Conversation

ywang-nr commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SQUASH MERGE

Uh oh!

codecov bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cmcadams-newrelic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmcadams-newrelic commented Aug 14, 2025

Uh oh!

ywang-nr commented Aug 15, 2025

Uh oh!

cmcadams-newrelic commented Aug 15, 2025

Uh oh!

ndesai-newrelic commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ywang-nr commented Aug 11, 2025 •

edited

Loading

codecov bot commented Aug 13, 2025 •

edited

Loading

ndesai-newrelic commented Aug 15, 2025 •

edited

Loading