-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Control log API through separate RUM flag #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 87.57% 87.51% -0.06%
==========================================
Files 201 201
Lines 7725 7723 -2
Branches 1564 1567 +3
==========================================
- Hits 6765 6759 -6
- Misses 828 830 +2
- Partials 132 134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi! I would love to get my hands on this feature! Is there an approximate release timeline? Currently, I find myself stuck having to allow my browser apps to ingest millions of unused logs monthly, just to get a few hundred relevant logs that I need to know about. |
A workaround, though obviously not the best solution, is to use version |
Supportability Metric Usage Changes:
Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
ptang-nr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Blocked until API team is out of code freeze and can implement settings changes. |
Logs captured by the
newrelic.logmethod will now be configurable through settings and controlled separately from wrapped logs. This allows one to be disabled without affecting the other, as in the case that onlynewrelic.logis desired and not auto instrumentedconsole.Overview
SM PR: https://source.datanerd.us/agents/angler/pull/740/files
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-399179
https://new-relic.atlassian.net/browse/NR-413528
https://new-relic.atlassian.net/browse/NR-411528
Testing
Added