Skip to content

Conversation

@cwli24
Copy link
Contributor

@cwli24 cwli24 commented May 5, 2025

Logs captured by the newrelic.log method will now be configurable through settings and controlled separately from wrapped logs. This allows one to be disabled without affecting the other, as in the case that only newrelic.log is desired and not auto instrumented console.

Overview

SM PR: https://source.datanerd.us/agents/angler/pull/740/files Static Badge

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-399179
https://new-relic.atlassian.net/browse/NR-413528
https://new-relic.atlassian.net/browse/NR-411528

Testing

Added

@github-actions
Copy link

github-actions bot commented May 5, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.07 kB / 9.84 kB (gzip) 26.07 kB / 9.84 kB (gzip) 0% / -0.02% (gzip)
lite async-chunk 54.56 kB / 18.02 kB (gzip) 54.58 kB / 18.02 kB (gzip) 0.03% / 0.04% (gzip)
pro loader 53.78 kB / 19.04 kB (gzip) 53.83 kB / 19.06 kB (gzip) 0.1% / 0.14% (gzip)
pro async-chunk 91.99 kB / 28.53 kB (gzip) 92.13 kB / 28.67 kB (gzip) 0.15% / 0.47% (gzip)
spa loader 62.54 kB / 21.74 kB (gzip) 62.59 kB / 21.76 kB (gzip) 0.08% / 0.12% (gzip)
spa async-chunk 116.57 kB / 35.52 kB (gzip) 116.71 kB / 35.67 kB (gzip) 0.12% / 0.43% (gzip)

@github-actions
Copy link

github-actions bot commented May 5, 2025

Static Badge

Last ran on August 08, 2025 16:37:38 CDT
Checking merge of (c7755f2) into main (dae94d3)

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.51%. Comparing base (ffc647c) to head (66a91eb).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/features/logging/aggregate/index.js 76.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   87.57%   87.51%   -0.06%     
==========================================
  Files         201      201              
  Lines        7725     7723       -2     
  Branches     1564     1567       +3     
==========================================
- Hits         6765     6759       -6     
- Misses        828      830       +2     
- Partials      132      134       +2     
Flag Coverage Δ
unit-tests 79.36% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lmuraru-plenty
Copy link

Hi!

I would love to get my hands on this feature! Is there an approximate release timeline?

Currently, I find myself stuck having to allow my browser apps to ingest millions of unused logs monthly, just to get a few hundred relevant logs that I need to know about.

@Kai-Richardson
Copy link

Currently, I find myself stuck having to allow my browser apps to ingest millions of unused logs monthly, just to get a few hundred relevant logs that I need to know about.

A workaround, though obviously not the best solution, is to use version 1.282 - since that's right before the auto-logging was added.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Supportability Metric Usage Changes:

File Content
src/features/logging/aggregate/index.js this.reportSupportabilityMetric(LOGGING_EVENT + Dropped/Sampling)
src/features/logging/aggregate/index.js this.reportSupportabilityMetric(LOGGING_EVENT + Dropped/Casting)
src/features/logging/aggregate/index.js if (this.events.add(log, targetEntityGuid)) this.reportSupportabilityMetric(LOGGING_EVENT + (autoCaptured ? Auto : API) + /Added)

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@metal-messiah metal-messiah self-assigned this Aug 18, 2025
@cwli24 cwli24 removed the Blocked label Sep 5, 2025
ptang-nr
ptang-nr previously approved these changes Sep 11, 2025
Copy link
Contributor

@ptang-nr ptang-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal-messiah
Copy link
Member

Blocked until API team is out of code freeze and can implement settings changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants