Skip to content

Conversation

@metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Oct 27, 2025

To help prevent data loss, the agent will now retry the original "RUM" call an extra time for retryable status codes.

Overview

Related Issue(s)

Angler PR

https://source.datanerd.us/agents/angler/pull/757

Issue

https://new-relic.atlassian.net/browse/NR-137656?atlOrigin=eyJpIjoiNjI5ODU3OTNkMDA3NDk3ZTg5ODk2YzEwYjgzMjQxNjciLCJwIjoiaiJ9

Testing

New tests have been added to ensure the RUM request is retried and is identical, and subsequent feature will harvest.

@github-actions
Copy link

Supportability Metric Usage Changes:

File Content
src/common/harvest/harvester.js const reportSM = (message) => handle(SUPPORTABILITY_METRIC_CHANNEL, [message], undefined, FEATURE_NAMES.metrics, aggregateInst.ee)

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? true

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@metal-messiah metal-messiah changed the title chore: add rum retry logic and tests feat: Retry initial connect call Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.96 kB / 9.8 kB (gzip) 25.96 kB / 9.8 kB (gzip) 0% / -0.03% (gzip)
lite async-chunk 53.84 kB / 18.05 kB (gzip) 54.01 kB / 18.09 kB (gzip) 0.31% / 0.23% (gzip)
pro loader 54.39 kB / 19.23 kB (gzip) 54.39 kB / 19.23 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 92.49 kB / 29 kB (gzip) 92.66 kB / 29.06 kB (gzip) 0.18% / 0.2% (gzip)
spa loader 63.24 kB / 21.92 kB (gzip) 63.24 kB / 21.93 kB (gzip) 0% / 0.01% (gzip)
spa async-chunk 117.9 kB / 36.32 kB (gzip) 118.07 kB / 36.35 kB (gzip) 0.14% / 0.07% (gzip)

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.36%. Comparing base (41d9d3b) to head (68c3206).

Files with missing lines Patch % Lines
src/features/page_view_event/aggregate/index.js 33.33% 11 Missing and 1 partial ⚠️
src/common/harvest/harvester.js 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
- Coverage   88.51%   88.36%   -0.15%     
==========================================
  Files         206      206              
  Lines        7760     7772      +12     
  Branches     1591     1589       -2     
==========================================
- Hits         6869     6868       -1     
- Misses        779      791      +12     
- Partials      112      113       +1     
Flag Coverage Δ
unit-tests 81.68% <42.85%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Static Badge

Last ran on November 05, 2025 10:09:58 CST
Checking merge of (159f2ae) into main (41d9d3b)

cwli24
cwli24 previously approved these changes Nov 4, 2025
cwli24
cwli24 previously approved these changes Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants