Skip to content

Use sprintf when logging to console with NRlogger #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use sprintf when logging to console with NRlogger #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6238db2
Use sprintf when logging to console with NRlogger
cdillard-NewRelic May 2, 2025
88c6d11
Use fputs and fflush
cdillard-NewRelic May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Agent/Utilities/NRLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,14 +243,16 @@ - (void)addLogMessage:(NSDictionary *)message : (BOOL) agentLogsOn {
BOOL shouldLog = (self->logLevels & level) != 0;

if ((self->logTargets & NRLogTargetConsole) && shouldLog && ![NRAutoLogCollector hasRedirectedStdOut]) {
NSLog(@"NewRelic(%@,%p):\t%@:%@\t%@\n\t%@",
[NewRelicInternalUtils agentVersion],
[NSThread currentThread],
[message objectForKey:NRLogMessageFileKey],
[message objectForKey:NRLogMessageLineNumberKey],
[message objectForKey:NRLogMessageMethodKey],
[message objectForKey:NRLogMessageMessageKey]);


NSString *log = [NSString stringWithFormat:@"NewRelic(%@,%p):\t%@:%@\t%@\n\t%@\n",
[NewRelicInternalUtils agentVersion],
[NSThread currentThread],
[message objectForKey:NRLogMessageFileKey],
[message objectForKey:NRLogMessageLineNumberKey],
[message objectForKey:NRLogMessageMethodKey],
[message objectForKey:NRLogMessageMessageKey]];
fputs([log cStringUsingEncoding:NSUTF8StringEncoding], stderr);
fflush(stderr);
}
// Only enter this block if remote logging is including this messages level.

Expand Down
Loading