v10.0.0 - Remove newrelic deployments and Capistrano support
#3299
Conversation
hannahramadan
changed the title
newrelic deployments and Capistrano support
SimpleCov Report
|
| end | ||
|
|
||
| def self.api_host | ||
| # only used for deployment task |
There was a problem hiding this comment.
I'm unsure on this. We use api_host in tests and in the ServerMethods module. Instead of removing this method, its been refactored to not use api_key
There was a problem hiding this comment.
I wonder what this looked like before we made the changes for API key? Do we still need the 'api' condition for the ServerModule?
There was a problem hiding this comment.
This is the change when we added api key https://github.com/newrelic/newrelic-ruby-agent/pull/1461/files#diff-d116d3c8c7bebe204a18ee3983ac59c5d15bd70da7123f2a2c4a12f144bca181
B
Also, i think we can remove it from server module, because that is only used by the api_server method which is just used by the deployments. I think we can just remove this method entirely and anything that's using it tbh. I think the only api we have ever used it for is deployments.
hannahramadan
changed the title
newrelic deployments and Capistrano supportnewrelic deployments and Capistrano support
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks for taking care of this, @hannahramadan!
There's a few other spots in the repo with references to deployments I found that you may want to take a look at:
- rubocop_todos.yml
- lib/new_relic/cli/command.rb: I don't think that file needs to be removed, but there's some mention of deployments.
- lib/new_relic/control/server_methods.rb: The ServerMethods class also has a comment about deployments that might be good to clean up to avoid confusion and replace with whatever that method is used for today (if it's still used)
| end | ||
|
|
||
| def self.api_host | ||
| # only used for deployment task |
There was a problem hiding this comment.
I wonder what this looked like before we made the changes for API key? Do we still need the 'api' condition for the ServerModule?
| # frozen_string_literal: true | ||
|
|
||
| # Add your own tasks in files placed in lib/tasks ending in .rake, | ||
| # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake. |
There was a problem hiding this comment.
I don't think this has to be removed because it's part of the Rails boilerplate, but taking it out isn't hurting anything either. Just wanted to call it out in case it comes back if we generate Rails 8.1 apps before this gets merged.
Remove support for
newrelic deploymentsand Capistrano