Stepping stone: Accept default, adaptive, always_on and always off for three samplers #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the allowlist functionality now that is faster.
default, adaptive, always_on, always_off are now available for use when a trace is root, remote_parent_sampled or remote_parent_not_sampled. default is first in the case list because it is the most common. I predict adaptive will be far less common than always_on or always_off, so I put it last for a slight performance benefit.
Contributor
SimpleCov Report
|
kaylareopelle
commented
Oct 31, 2025
| } | ||
| } | ||
| }, | ||
| { |
Contributor
Author
There was a problem hiding this comment.
This isn't part of the cross-agent tests right now, but I think I'll open a PR for it.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a step toward implementing the trace ID ratio based sampler.
This PR creates a consistent pattern for the root sampler, as well as when the sampling decision is made in trace context, or using the newrelic header (in
lib/new_relic/agent/transaction/distributed_tracing.rb).It also removes old code that isn't being used, the
enforce_fallbackmethod. The configs that used this option no longer exist. Theallowlistfunctionality is much more performant and is used here instead.Case statements are evaluated in order, so I ordered the when statements by my best judgment of what is most and least likely to occur.