Add sidekiq.ignore_retry_errors to defer error reporting
#3317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jobs are notified only once.
…io/newrelic-ruby-agent into sidekiq_notice_only_once
Testing branch sidekiq config
Contributor
SimpleCov Report
|
Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@60a0d83...ed59741) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…jobs are notified only once.
hannahramadan
changed the title
sidekiq.ignore_retry_errors to defer error reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration key
sidekiq.ignore_retry_errors.When
sidekiq.ignore_retry_errorsisfalse(Default), an error is sent to New Relic on every job failure, including retries.When
sidekiq.ignore_retry_errorsistrue, the agent will reports an error to New Relic only once, after the job has failed all retries and is moved to the "Dead" set.Thanks to @DonGiulio for this contribution.