Skip to content

Rename ActiveJob segments #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v10_0_0
Choose a base branch
from
Open

Rename ActiveJob segments #3320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1282b59
Rename active_job segment
hannahramadan Nov 7, 2025
5e7c4aa
Remove binding
hannahramadan Nov 7, 2025
fd19019
Grab last class, not full class
hannahramadan Nov 7, 2025
9ba2786
Update test
hannahramadan Nov 7, 2025
acd0238
Add CHANGELOG
hannahramadan Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
- **Breaking Change: Removed support for Ruby 2.4 and 2.5**
Support for Ruby versions 2.4 and 2.5 has been removed. The new minimum required Ruby version is now 2.6. [PR#3314](https://github.com/newrelic/newrelic-ruby-agent/pull/3314)

- **Breaking Change: Renamed ActiveJob metrics**
ActiveJob metrics have been updated to include the job's class name for more specific reporting. This is a breaking change and may require updating custom dashboards or alerts. [PR#3320](https://github.com/newrelic/newrelic-ruby-agent/pull/3320)
- Old format: `Ruby/ActiveJob/<QueueName>/<Method>`
- New format: `Ruby/ActiveJob/<ClassName>/<QueueName>/<Method>`

## v9.23.0

- **Feature: Deprecation notice for recording deployments using Capistrano**
Expand Down
3 changes: 2 additions & 1 deletion lib/new_relic/agent/instrumentation/active_job_subscriber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ def metric_name(name, payload)
job = payload[:job] || payload[:jobs].first

queue = job.queue_name
job_class = job.class.name.split('::').last
method = method_from_name(name)
"Ruby/ActiveJob/#{queue}/#{method}"
"Ruby/ActiveJob/#{job_class}/#{queue}/#{method}"
end

PATTERN = /\A([^\.]+)\.active_job\z/
Expand Down
6 changes: 3 additions & 3 deletions test/new_relic/agent/instrumentation/rails/active_job_subscriber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ class ActiveJobSubscriberTest < Minitest::Test
SUBSCRIBER = NewRelic::Agent::Instrumentation::ActiveJobSubscriber.new

def test_segment_naming_with_unknown_method
assert_equal 'Ruby/ActiveJob/default/Unknown',
assert_equal 'Ruby/ActiveJob/TestJob/default/Unknown',
SUBSCRIBER.send(:metric_name, 'indecipherable', {job: TestJob.new})
end

def test_segment_naming_multiple_jobs
assert_equal 'Ruby/ActiveJob/default/Unknown',
assert_equal 'Ruby/ActiveJob/TestJob/default/Unknown',
SUBSCRIBER.send(:metric_name, 'indecipherable', {jobs: [TestJob.new, TestJob.new]})
end

Expand Down Expand Up @@ -109,7 +109,7 @@ def validate_transaction(txn, methods = [])
refute_empty segments

methods.each do |method|
segment = segments.detect { |s| s.name == "Ruby/ActiveJob/default/#{method}" }
segment = segments.detect { |s| s.name == "Ruby/ActiveJob/TestJob/default/#{method}" }

assert segment

Expand Down
Loading