-
Notifications
You must be signed in to change notification settings - Fork 19
fix: address transformprocessor config deprecation of 0.119.0 #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
PR title 'modify transform processor config to comply with 0.199.0 version bump' does not adhere to conventional commits. Change PR title to ensure that the suggested squash commit follows the conventions and thus ends up in the changelog. |
|
Fix LGTM but we should include a test to prevent regression and ensure that it actually works. One way to do that would be to leverage the local e2e tests and add a condition that this log entry is no longer present. It's then trivial to verify that this fix works by running the test without your config fix (expecting test to fail) and with the fix (expecting test to pass). The log should be queryable with something like |
The merge-base changed after approval.
The merge-base changed after approval.
e69a71e to
1289e19
Compare
6caabb6 to
72224d6
Compare
72224d6 to
9d3e5c4
Compare
addressing these logs in
CI | Nightly Tests