Skip to content

Conversation

@emiliaFer
Copy link
Contributor

@emiliaFer emiliaFer commented Oct 22, 2025

addressing these logs in CI | Nightly Tests

[email protected]/parser_collection.go:364	
one or more statements were modified to include their paths context, please rewrite them accordingly	
{
  "kind": "processor", 
    "name": "transform/truncate", 
      "pipeline": "logs", 
      "statements": {"[0]": {
        "original": "truncate_all(attributes, 4095)", 
        "modified": "truncate_all(log.attributes, 4095)"
      }
    }
}

@emiliaFer emiliaFer requested a review from a team as a code owner October 22, 2025 18:38
@github-actions
Copy link

PR title 'modify transform processor config to comply with 0.199.0 version bump' does not adhere to conventional commits. Change PR title to ensure that the suggested squash commit follows the conventions and thus ends up in the changelog.

@emiliaFer emiliaFer changed the title modify transform processor config to comply with 0.199.0 version bump chore: modify transform processor config to comply with 0.199.0 version bump Oct 22, 2025
@kb-newrelic
Copy link
Contributor

kb-newrelic commented Oct 22, 2025

Fix LGTM but we should include a test to prevent regression and ensure that it actually works. One way to do that would be to leverage the local e2e tests and add a condition that this log entry is no longer present. It's then trivial to verify that this fix works by running the test without your config fix (expecting test to fail) and with the fix (expecting test to pass).

The log should be queryable with something like FROM Log select count(*) where message = 'one or more paths were modified to include their context prefix, please rewrite them accordingly' but make sure to verify that yourself. Over time we'll want to transform that condition into something more general but that can happen in NR-389681

kb-newrelic
kb-newrelic previously approved these changes Oct 28, 2025
@emiliaFer emiliaFer dismissed kb-newrelic’s stale review October 28, 2025 22:09

The merge-base changed after approval.

kb-newrelic
kb-newrelic previously approved these changes Oct 28, 2025
@emiliaFer emiliaFer dismissed kb-newrelic’s stale review October 28, 2025 22:14

The merge-base changed after approval.

@kb-newrelic kb-newrelic force-pushed the emiliaFer/transformProcessorBug branch from e69a71e to 1289e19 Compare October 29, 2025 16:59
kb-newrelic
kb-newrelic previously approved these changes Oct 29, 2025
@kb-newrelic kb-newrelic force-pushed the emiliaFer/transformProcessorBug branch from 6caabb6 to 72224d6 Compare October 29, 2025 17:05
@kb-newrelic kb-newrelic force-pushed the emiliaFer/transformProcessorBug branch from 72224d6 to 9d3e5c4 Compare October 29, 2025 17:09
kb-newrelic
kb-newrelic previously approved these changes Oct 29, 2025
@kb-newrelic kb-newrelic changed the title chore: modify transform processor config to comply with 0.199.0 version bump chore: address transformprocessor config deprecation of 0.119.0 Oct 29, 2025
@kb-newrelic kb-newrelic changed the title chore: address transformprocessor config deprecation of 0.119.0 fix: address transformprocessor config deprecation of 0.119.0 Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants