Skip to content

Conversation

@rtizzy
Copy link

@rtizzy rtizzy commented Apr 15, 2025

Description

This:

  1. Modifies the AWS Firehose metrics stream example to allow it's use in multi-region setup
  2. Solves a perpetual diff.
  3. Sets some defaults based on the guidelines in NR documentation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  1. Apply something similar to the following that uses the previous version of the example
  2. Apply it again and note the perpetual diff.
module "newrelic-aws-cloud-integrations-us-east-1" {
  providers = {
    aws = aws.us-east-1
  }
  source = $PREVIOUSMODULEVERSIONHERE

  newrelic_account_id     = local.newrelic_account_id
  newrelic_account_region = "US"
  name                    = "primary"
}
  1. Apply this code with the previous version of the module
  2. It fails.
module "newrelic-aws-cloud-integrations-us-east-1" {
  providers = {
    aws = aws.us-east-1
  }
  source = "../../../../../terraform-provider-newrelic//examples/modules/cloud-integrations/aws"

  newrelic_account_id     = local.newrelic_account_id
  newrelic_account_region = "US"
  name                    = "primary"
}

module "newrelic-aws-cloud-integrations-us-west-2" {
  providers = {
    aws = aws.us-west-2
  }
  source = "../../../../../terraform-provider-newrelic//examples/modules/cloud-integrations/aws"

  newrelic_account_id     = local.newrelic_account_id
  newrelic_account_region = "US"
  name                    = "us-west-2"
  is_primary_region       = false
}
  1. Apply the previous code with this version of the module.
  2. It doesn't fail
  3. Apply it again.
  4. There isn't a perpetual diff.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2025

CLA assistant check
All committers have signed the CLA.

@rtizzy rtizzy changed the title Modify AWS Metrics Stream to be usable in multiple regions, resolve a perpetual diff. Modify AWS Metrics Stream to be usable in multiple regions, resolve a perpetual diff, configure API Pull only for unsupported services Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants