fix: Preserve card description/due date on cloning #7345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
juliusknorr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit already fixes the issue as the call to setDescription was not detected as an update. With our wrapped Card entity we did proxy getters and setters to the internal card object but not the getUpdatedFields method.
The second commit however takes a shortcut to set the description and due date directly and not require another update query.