Skip to content

Conversation

@zdm
Copy link

@zdm zdm commented Jul 22, 2025

Under cygwin environment ln -s works incorrectly and creates full copy instead of a symbolic link.
This patch fix this problem by using Windows mklink command to create directory junction.

@zdm
Copy link
Author

zdm commented Jul 23, 2025

Also .editorconfig was fixed, off value is not allowed by the specification and was replaced with unset.

@ljharb
Copy link
Member

ljharb commented Jul 23, 2025

Can you link to where false and off aren't specified, and unset is mandated?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a regression test, that would have failed without the fix.


# Linux or other environment
command rm -f "${NVM_DIR}/current" && ln -s "${NVM_VERSION_DIR}" "${NVM_DIR}/current"
;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
;;
;;

@zdm
Copy link
Author

zdm commented Jul 23, 2025

https://editorconfig.org/

You can see list of allowed values there. Aslo there is common special value unset;

Currently all properties and values are case-insensitive. They are lowercased when parsed. Generally, if a property is not specified, the editor settings will be used, i.e. EditorConfig takes no effect on that part. For any property, a value of unset is to remove the effect of that property, even if it has been set before. For example, add indent_size = unset to undefine indent_size property (and use editor default).

@zdm
Copy link
Author

zdm commented Jul 26, 2025

I will close this PR, absolutely have no time to finish it.

@zdm zdm closed this Jul 26, 2025
@ljharb
Copy link
Member

ljharb commented Jul 26, 2025

That’s very unfortunate you deleted the fork; now nobody else can finish it for you.

@zdm
Copy link
Author

zdm commented Jul 27, 2025

Oh, I am sorry. Usually PRs are not needed by anybody ;-)
In any case patch is viewable in the PR's changed files, you still can apply it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants