Skip to content

Conversation

@ynezz
Copy link
Member

@ynezz ynezz commented Jan 7, 2024

Merging pull request openwrt/openwrt#14218 (with all 190 CI checks green) resulted in buildbot failures in Kernel/CollectDebug step, likely due to the fact, that CI builds don't use same config options as on buildbot, specifically CI builds currently don't have COLLECT_KERNEL_DEBUG config option enabled.

So lets try to prevent those regressions in the future by aligning the CI build process with the build config options used later on the buildbots.

References: 066b0fee7668 ("kernel: copy only *.ko for debug info")
References: openwrt/openwrt#14218


Just quickly drafted to start discussion about the improvements, so untested as well...

@ynezz ynezz marked this pull request as draft January 7, 2024 19:04
@ynezz ynezz changed the title Try to prevent harder buildbot failures RFC: Try to prevent harder buildbot failures Jan 7, 2024
@Ansuel
Copy link
Member

Ansuel commented Jan 7, 2024

@ynezz any reason why they are not part of the CONFIG_BUILDBOT option?

@ynezz
Copy link
Member Author

ynezz commented Jan 7, 2024

@ynezz any reason why they are not part of the CONFIG_BUILDBOT option?

Uh, they're part of CONFIG_BUILDBOT option, but we're not setting it on the CI for some reason (another such regression).

@Ansuel
Copy link
Member

Ansuel commented Jan 7, 2024

@ynezz guess the problem is for kernel build where we would build way too much packages. Should we introduce the CONFIG_CI option?

@ynezz
Copy link
Member Author

ynezz commented Jan 7, 2024

@ynezz guess the problem is for kernel build where we would build way too much packages.

Check the diff, I've tried to split it into multiple cheap/expensive parts and tried to enable the expensive parts only where it makes sense.

Should we introduce the CONFIG_CI option?

I would just try to keep the buildbot settings with CI somehow in the sync manually, when we find out buildbot failure like in this case, just enable the test case on the CI, IMO no need to complicate it with some other config option, looks like overkill to me.

working-directory: openwrt
run: |
echo CONFIG_DEVEL=y >> .config
echo CONFIG_SDK_LLVM_BPF=y >> .config
Copy link
Member Author

@ynezz ynezz Jan 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure where to put this config option, had it initially in the next Configure SDK and IB options used on buildbots step, will recheck later.

@aparcar
Copy link
Member

aparcar commented Apr 2, 2024

I think this looks good

ynezz added 3 commits November 6, 2024 11:52
Its the latest version currently being used by buildbots.

Signed-off-by: Petr Štetiar <[email protected]>
Merging pull request #14218 (with all 190 CI checks green) resulted in
buildbot failures in `Kernel/CollectDebug` step, likely due to the fact,
that CI builds don't use same config options as on buildbot,
specifically CI builds currently don't have `COLLECT_KERNEL_DEBUG`
config option enabled.

So lets try to prevent those regressions in the future by aligning the
CI build process with the build config options used later on the
buildbots.

References: 066b0fee7668 ("kernel: copy only *.ko for debug info")
References: openwrt/openwrt#14218
Signed-off-by: Petr Štetiar <[email protected]>
Currently during opkg->apk switch we're seeing a lot of regressions here
and there, so lets QA this part a bit to prevent those using the new
tools-smoke-test.sh script.

Signed-off-by: Petr Štetiar <[email protected]>
@ynezz ynezz force-pushed the ynezz/buildbot-config branch from 03cbb58 to 27eb2d8 Compare November 6, 2024 12:07
@ynezz ynezz changed the title RFC: Try to prevent harder buildbot failures Try to prevent harder buildbot failures Nov 6, 2024
@ynezz
Copy link
Member Author

ynezz commented Nov 6, 2024

Being tested in here openwrt/openwrt#16873

@Ansuel Ansuel force-pushed the main branch 2 times, most recently from 7ef03b6 to 0a3f3c9 Compare November 8, 2024 18:26
@Ansuel Ansuel force-pushed the main branch 2 times, most recently from 94e64ba to c7ec823 Compare July 24, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants