sstp: correct certificate handling #27727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `--cert-warn` this silently ignores certificate warnings. Removing it so the connection is properly terminated. Reported-by: Alexander Patrakov <[email protected]> Signed-off-by: Paul Spooren <[email protected]>
Contributor
|
Does not work - sstp-client needs an explicit path to certificates. You need: And still doesn't work because of #27318. |
Contributor
|
And I think there is a significant user base that connects to SSTP servers by IP with invalid or self-signed certificates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @fededim
Description:
By using
--cert-warnthis silently ignores certificate warnings. Removing it so the connection is properly terminated.🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.