Skip to content

mwan3: refresh source ip in mwan3track #27745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

mwan3: refresh source ip in mwan3track #27745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion net/mwan3/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=mwan3
PKG_VERSION:=2.12.0
PKG_RELEASE:=3
PKG_RELEASE:=4

PKG_MAINTAINER:=Florian Eckert <[email protected]>
PKG_LICENSE:=GPL-2.0
Expand Down
2 changes: 2 additions & 0 deletions net/mwan3/files/usr/sbin/mwan3track
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ main() {
wait $!
}
sleep_time=$interval
network_flush_cache
mwan3_get_src_ip SRC_IP $INTERFACE
Copy link
Member

@feckert feckert Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the call of network_flush_cache into the function mwan3_get_src_ip. If some in the future needs the function mwan3_get_src_ip anywere else in mwan3. The developer needs to know that the function network_flush_cache needs to be called first to get the latest SRPC_IP value.

We also call this function there

packages/net/mwan3/files/usr/sbin/mwan3

Line 229 in 1a46649

mwan3_get_src_ip src_ip $interface
too.

Copy link
Author

@l-jonas l-jonas Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with that. The other place where this is used in mwan3track (in firstconnect), there is also the manual call to network_flush_cache. This only refers to a cache within the bash script.

mwan3 use is short running/only calls the function once. Thus, there is no moment where this could be refreshed.

for track_ip in $track_ips; do
if [ $host_up_count -lt $reliability ]; then
case "$track_method" in
Expand Down