libid3tag: require cmake >= 3.10 due to removed legacy support

[marcinmajsc]

Link: #27607

Link: openwrt/openwrt@1b48ebd

📦 Package Details

Maintainer: Ted Hess [email protected]
_{https://codeberg.org/tenacityteam/libid3tag.git}

Description:
libid3tag is a library for reading and (eventually) writing ID3 tags, both ID3v1 and the various versions of ID3v2

---

🧪 Run Testing Details

• OpenWrt Version: master
• OpenWrt Target/Subtarget:
• OpenWrt Device:

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

• It can be applied using git am
• It has been refreshed to avoid offsets, fuzzes, etc., using

  make package/feeds/packages/libid3tag/refresh V=s

• It is structured in a way that it is potentially upstreamable
  _{(e.g., subject line, commit description, etc.)
  We must try to upstream patches to reduce maintenance burden.}

[BKPepe]

I'd say that in this case, I'd prefer if the number in PKG_RELEASE, which you can find in the Makefile, was incremented, because that will help us know and distinguish which version contains this fix or not. Others might have a different opinion though. :) This looks better than before.

[marcinmajsc]

I'd say that in this case, I'd prefer if the number in PKG_RELEASE, which you can find in the Makefile, was incremented, because that will help us know and distinguish which version contains this fix or not. Others might have a different opinion though. :) This looks better than before.

Did you mean something like this? marcinmajsc@e0bcbb2

[hnyman]

Did you mean something like this? marcinmajsc@e0bcbb2

Likely yes. Incrementing that makes it clear that there has been a change.

(although in this case it likely doesn't mean much, as we are already happily compiling the packages with cmake 3.31, so bumping the min requirement from a really ancient version 3.1 to a semi.ancient version 3.10 is likely a rather null-op change)

[marcinmajsc]

Likely yes. Incrementing that makes it clear that there has been a change.

(although in this case it likely doesn't mean much, as we are already happily compiling the packages with cmake 3.31, so bumping the min requirement from a really ancient version 3.1 to a semi.ancient version 3.10 is likely a rather null-op change)

Ok, so what now do it in PR? @hnyman @BKPepe

• Current patch stay + bump PKG_RELEASE in Makefile
• Replace commit in PR with marcinmajsc@e0bcbb2 (in makefile changed source version to upstream commit, rm mirror hash and bump PKG_RELEASE)

[hnyman]

Current patch stay + bump PKG_RELEASE in Makefile

That would be perfect.
Taking the actual upstream commit is always nice, and bumping the PKG_RELEASE makes it clear that there is a change.