In batch mode, print empty line if get fails #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Cather <[email protected]>
Currently get commands return nothing to stdout on error in batch mode. In practice, this makes them hard to use in scripts. If the caller sends 4 gets and we only return 3 lines, the caller can not easily determine which one did not work. This changes the get command behavior in batch mode to always print a new line, even on error. This allows the caller to determine which get did not work. e.x. if the 3rd line is blank then the 3rd get did not work. Signed-off-by: Matthew Cather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently get commands return nothing to stdout on error in batch mode. In practice, this makes them hard to use in scripts. If the caller sends 4 gets and we only return 3 lines, the caller can not easily determine which one did not work.
This changes the get command behavior in batch mode to always print a new line, even on error. This allows the caller to determine which get did not work. e.x. if the 3rd line is blank then the 3rd get did not work.
Also fixes #3
CC: @cmonroe