removes alias in fepois #1072
Merged
removes alias in fepois #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dpananos
commented
Nov 10, 2025
| _solver = self._solver | ||
|
|
||
| def compute_deviance(_Y: np.ndarray, mu: np.ndarray): | ||
| def compute_deviance(Y: np.ndarray, mu: np.ndarray): |
Contributor
Author
There was a problem hiding this comment.
Should this be a class method and not defined inside get_fit?
Member
There was a problem hiding this comment.
Yes, I think this would make sense 👍 Do you want to add the change to this PR?
Member
There was a problem hiding this comment.
Actually, let's just do it in a separate PR, I want to merge this one. 😄 Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
s3alfisc
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854