ENH: Support python 2. #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial cut of support for python 2. Notable deficiencies: - Removes keyword-only args from several API functions. - Changes `BytesIO.getbuffer()` to `BytesIO.getvalue()`. This is almost certainly a significant performance regression for large loads. At the very least, it should be made conditional by python version. It's an open question whether the extra copy incurred by calling `getvalue()` makes this even worth doing. If not, we'd probably have to vendor a py2-compat BytesIO-like object to support zero-copy reads.
Author
|
Not sure if this is actually worth doing, but, I was seeing unreasonable memory usage for fundamentals queries on Q over the weekend, and wanted to at least test to see if warp_prism improved that situation. |
Contributor
|
In Python 2 cStringIO has a C API where you can read from the underlying buffer. There is a capsule called Even with the |
Author
Don't know, I haven't actually used this yet other than getting the tests to pass in py2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial cut of support for python 2.
Notable deficiencies:
Removes keyword-only args from several API functions.
Changes
BytesIO.getbuffer()toBytesIO.getvalue(). This is almostcertainly a significant performance regression for large loads. At the
very least, it should be made conditional by python version. It's an
open question whether the extra copy incurred by calling
getvalue()makes this even worth doing. If not, we'd probably have to vendor a
py2-compat BytesIO-like object to support zero-copy reads.