Increase worker count for reconcilers #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
reviewed
Sep 25, 2024
weyfonk
approved these changes
Sep 25, 2024
This should reflect the old settings from 0.9
manno
force-pushed
the
increase-worker-count
branch
from
75c18e2 to
74632ad
Compare
weyfonk
approved these changes
Sep 25, 2024
manno
force-pushed
the
increase-worker-count
branch
from
74632ad to
db8f9f2
Compare
weyfonk
reviewed
Sep 27, 2024
| }), | ||
| ). | ||
| WithEventFilter(sharding.FilterByShardID(r.ShardID)). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: 50}). |
Contributor
There was a problem hiding this comment.
Now I think that at least this one should also be made configurable.
Member
Author
There was a problem hiding this comment.
Yes, that's a good follow-up story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2899
This should reflect the old settings from 0.9
In Rancher this can be configured by changing Fleet's installation options: