Skip to content

Remove empty fields from gitrepo/bd resources #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove empty fields from gitrepo/bd resources #2901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions charts/fleet-crd/templates/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ spec:
helm:
description: Helm options for the deployment, like the chart
name, repo and values.
nullable: true
properties:
atomic:
description: Atomic sets the --atomic flag when Helm is
Expand Down Expand Up @@ -622,7 +621,6 @@ spec:
helm:
description: Helm options for the deployment, like the chart
name, repo and values.
nullable: true
properties:
atomic:
description: Atomic sets the --atomic flag when Helm is
Expand Down Expand Up @@ -1456,7 +1454,6 @@ spec:
helm:
description: Helm options for the deployment, like the chart name,
repo and values.
nullable: true
properties:
atomic:
description: Atomic sets the --atomic flag when Helm is performing
Expand Down Expand Up @@ -2301,7 +2298,6 @@ spec:
helm:
description: Helm options for the deployment, like the chart
name, repo and values.
nullable: true
properties:
atomic:
description: Atomic sets the --atomic flag when Helm is
Expand Down Expand Up @@ -6237,20 +6233,17 @@ spec:
authorEmail:
description: AuthorEmail gives the email to provide when making
a commit
nullable: true
type: string
authorName:
description: AuthorName gives the name to provide when making
a commit
nullable: true
type: string
messageTemplate:
description: 'MessageTemplate provides a template for the commit
message,

into which will be interpolated the details of the change
made.'
nullable: true
type: string
type: object
imageScanInterval:
Expand Down
3 changes: 2 additions & 1 deletion pkg/apis/fleet.cattle.io/v1alpha1/bundledeployment_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ type BundleDeploymentOptions struct {
Kustomize *KustomizeOptions `json:"kustomize,omitempty"`

// Helm options for the deployment, like the chart name, repo and values.
// +nullable
// +optional
Helm *HelmOptions `json:"helm,omitempty"`

// ServiceAccount which will be used to perform this deployment.
Expand All @@ -98,6 +98,7 @@ type BundleDeploymentOptions struct {
DeleteNamespace bool `json:"deleteNamespace,omitempty"`

//IgnoreOptions can be used to ignore fields when monitoring the bundle.
// +optional
IgnoreOptions `json:"ignore,omitempty"`

// CorrectDrift specifies how drift correction should work.
Expand Down
3 changes: 0 additions & 3 deletions pkg/apis/fleet.cattle.io/v1alpha1/gitrepo_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,16 +306,13 @@ type ResourcePerClusterState struct {
type CommitSpec struct {
// AuthorName gives the name to provide when making a commit
// +optional
// +nullable
AuthorName string `json:"authorName"`
// AuthorEmail gives the email to provide when making a commit
// +optional
// +nullable
AuthorEmail string `json:"authorEmail"`
// MessageTemplate provides a template for the commit message,
// into which will be interpolated the details of the change made.
// +optional
// +nullable
MessageTemplate string `json:"messageTemplate,omitempty"`
}

Expand Down
Loading