Migrate bundle diffs tests to integration #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isolates them better from the agent implementation.
Those tests are now more lightweight in terms of runtime and maintenance, since they act directly on bundle deployments, without relying on `GitRepo`s nor bundles. Besides, this deletes a test case validating that adding data to a resource within a bundle deployment would work with bundle diffs, as that use case also works _without_ bundle diffs. This also adds a test case validating deletion of data covered by a bundle diff.
That path no longer exists, now that drift correction tests have been migrated over to integration tests.
manno
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of a first look into #2869, without resolving it but as an effort to better understand bundle diffs and normalizers.